4k displays support about vscode-chronicler HOT 21 CLOSED

Still working on it. I've confirmed that ffmpeg is not DPI aware. I'm working on this downstream. First step will be arciisine/win-info#1, and then arciisine/screen-recorder#3. After that I can update the plugin.

from vscode-chronicler.

from vscode-chronicler.

from vscode-chronicler.

@arciisine in vscode console I have devicePixelRatio 2.5

and for windows I have default scaling (250%)

from vscode-chronicler.

from vscode-chronicler.

This seems to point that I might need to have screen dpi awareness and do some multiplication on the coordinate system.

https://social.msdn.microsoft.com/Forums/vstudio/en-US/948ec624-a506-45f7-a347-3c166ba34cea/getwindowrect-on-windows-10?forum=vcgeneral.

I might be able to provide a test build this weekend if you have the time to verify @lifeart.

from vscode-chronicler.

Sure, thank you!

from vscode-chronicler.

@lifeart Okay, so modified the dependent libraries, and I've published a new version (0.1.9). Tested it on windows with multiple deskop scaling factors, and everything looked to be okay.

from vscode-chronicler.

@arciisine getting

from vscode-chronicler.

@lifeart What version are you running? I remember running into this with some oddness in the JSON output of window information. This was resolved in later builds.

from vscode-chronicler.

It’s 0.1.9 according to vscode

from vscode-chronicler.

So, I just pulled up 0.1.9 on my windows 10 VM and it appears to be working. If I provide a simple repository, would you be able to run it and provide some debug information? It would amount to running @arcsine/win-info commands to validate the bounds detection, as I believe this is where you are experiencing the problem.

from vscode-chronicler.

sure, no problem

from vscode-chronicler.

@lifeart , Try npx -p @arcsine/win-info win-info where you have npx installed.

C:\Users\User>npx -p @arcsine/win-info win-info
npx: installed 1 in 2.441s
{
  "title": "npm",
  "id": 393890,
  "owner": {
    "name": "cmd.exe",
    "processId": 7528,
    "path": "C:\\Windows\\System32\\cmd.exe"
  },
  "screens": [
    {
      "x": 0,
      "y": 0,
      "width": 1707,
      "height": 1027,
      "index": 0,
      "scale": {
        "x": 2.25,
        "y": 2.25
      }
    }
  ],
  "bounds": {
    "x": 198,
    "y": 198,
    "width": 932,
    "height": 511
  }
}

from vscode-chronicler.

from vscode-chronicler.

@lifeart The latest verison (0.2.9) of the above script has been published, if you want to give it a try

from vscode-chronicler.

@arciisine

{
    "title": "npm",
    "id": 920152,
    "owner": {
        "name": "WindowsTerminal.exe",
        "processId": 55928,
        "path": "C:\\Program Files\\WindowsApps\\Microsoft.WindowsTerminal_1.5.10271.0_x64__8wekyb3d8bbwe\\WindowsTerminal.exe"
    },
    "screens": [
        {
          "x": 0,
          "y": 0,
          "width": 1536,
          "height": 824,
          "index": 0,
          "scale": {
            "x": 2,50,
            "y": 2,50
          }
        } ],
    "bounds": {
        "x": 388,
        "y": 166,
        "width": 1146,
        "height": 619
    }
}

from vscode-chronicler.

looks like screens[0].scale.x should be 2.50 instead of 2,50 and same for y

from vscode-chronicler.

@lifeart Thanks, this looks to be an issue of localization tied to the string formatting. I'll get a release today or tomorrow.

from vscode-chronicler.

@lifeart Verified the fix, should be rolled out in the latest vscode chronicler update. Thanks for all the assistance in finding (and troubleshooting).

from vscode-chronicler.

@arciisine thank you for your work! I can confirm, it's working as expected! (v0.1.11)

from vscode-chronicler.