Giter Club home page Giter Club logo

Comments (2)

arch1t3cht avatar arch1t3cht commented on July 17, 2024

I assume you're talking about the subtitle edit box. (If you're talking about the actual rendering and the logic of how tags apply in RTL text, this is something that depends on the renderer and cannot be fixed on Aegisub's side.) The problem with this is that that box is a wxStyledTextCtrl from wxWidgets, the UI library Aegisub uses, and that this control has very poor RTL support that cannot be fixed from Aegisub's side. While there is an internal function to switch to an RTL layout, that also isn't perfect and only works for pure RTL text (i.e. has no bidi support). There is a draft PR open here that exposes this option in Aegisub, but it's not really complete yet.

Scintilla (which wxStyledTextCtrl uses internally) does have experimental bidi support, but this is only on Scintilla's Windows implementation and wxStyledTextCtrl uses wxWidgets's own implementation, so this feature does not actually do anything on wxStyledTextCtrl.

wangqr/Aegisub worked around this issue by adding a toggle to replace the subtitle edit box with a native text field. This has other downsides like losing syntax highlighting, but it'd correctly handle bidirectional text. I've tried to pull this change before, but I ran into various complications (huge merge conflicts, and lots of crashes once I did resolve the conflicts). I might try to revisit this at some point, but this will take some time (which I don't really have at the moment).

What I'm trying to say is: I'm very much aware of this issue and have tried various things to fix it before, but there's no good solution for it since LTR/bidi support in the underlying libraries is very poor.

from aegisub.

Dbooz avatar Dbooz commented on July 17, 2024

Ahh too bad, I've been working on Aegisub with this hassle for more than 12 years, so I got used to it by now.

Thank you very much for the detailed explanation and all your great efforts in development. Absolutely loving the dark mode while my wife is asleep. My eyes dreaded for so long lol. I appreciate it.

from aegisub.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.