REVIEW: what's the best way to set the RowId? about autohistory HOT 14 CLOSED

What is the purpose of AutoHistory? If to keep a track of all DB transactions -except reading- then ADD could be implemented.

But the newly inserted data is already in its own table , therefore there's no need to keep a duplicate data of it. Data auditing should include past actions, because the current data is already in the correct place: its own table, own row.

Besides, AutoHistory table will be a sum of all the database, including past versions of data. It's like an Excel worksheet with no removal support so that the update and delete actions are all in the same table. It's unusable.

By supporting add, which is already meaningless, the application should do two round trips for the same action: A data inserted in a table.

That's why I believe ADD should not be supported and the issue should be closed.

from autohistory.

@lotosbin or anyone, have anytime to close this issue?

from autohistory.

I can do it even if the primary key is a composite one.

from autohistory.

@alexmtnezf Thanks!, PR welcome!

from autohistory.

@alexmtnezf Are your PR ready?

from autohistory.

from autohistory.

yeah, PR = pull request

from autohistory.

ensure entity inserted before history.
and update history's rowId after entity inserted.

from autohistory.

@lotosbin Yes, this can solve the problem, but this cause a new route trip to database. So maybe not to support the ADD history, only record the modify history.

from autohistory.

Hi there,
Finally, do you plan to support the ADD history ?
Thanks,

from autohistory.

I have not good idea how to impl it in one db roundtrip right now.

from autohistory.

What if we use a package or code from other project hosted in GitHub, if its license is MIT we can use their code right?.

from autohistory.

Yep

from autohistory.

@feldrim AutoHistory not want to keep a track of all DB changing. The usage is only for recording some important changes.

That's why I believe ADD should not be supported and the issue should be closed.

I agree now.

from autohistory.