PopupViewImpl will trigger onLoad() / onAttach() twice for widgets inside it about gwtp HOT 10 CLOSED

The problem lies in PopupViewImpl doCenter() method.

private void doCenter() {
    boolean wasVisible = asPopupPanel().isShowing();
    asPopupPanel().center();
    if (!wasVisible) {
        asPopupPanel().hide();
    }
}

The method is using the GWT's PopupPanel center() method which state:
"Centers the popup in the browser window and shows it. If the popup was already showing, then the popup is centered."

http://google-web-toolkit.googlecode.com/svn/javadoc/1.5/com/google/gwt/user/client/ui/PopupPanel.html#center()

 
To resolve the issue, we would need to implement doCenter() without relying on PopupPanel

from gwtp.

Good catch.

I saw this too recently some else was having issues on centering.

from gwtp.

#13

from gwtp.

The fix I made does not fix the issue #13 as it seem to be more related to the CSS not being loaded when the getOffsetWidth() is called in doCenter().

from gwtp.

I think it solves one issue, shifting after its slightly rendered.

I noticed that it adds to the dom by root event, and then centers. But it would be nice to add more controls to that event process. It seems that the timing to attaching to the dom and center is fussy, in relation to the css, but I wanted to explore that more.

from gwtp.

One of my thoughts was instead of solving it, give control on when the centering occurs through the event, two step process, or see if I could wait for attaching event then center, but I wasn't sure that occurred before or after rendering of css.

from gwtp.

If the element is not attached when you try to center it, isn't that normal that the css is not taken into account for the calculs?

from gwtp.

Good point, it would have to be attached to get the width and height for calcs.

from gwtp.

Trying to find my source, but I was testing it out: http://gwtp-sandbox.appspot.com/

from gwtp.

I'm going to close this issue since fix was merged. I haven't heard anything on this for a while. I think we can iterate improvements as they come up.

This issue can be used to research the popup in closer detail in the future and help make improvements in the future.
#13

from gwtp.