Giter Club home page Giter Club logo

Comments (6)

valepu avatar valepu commented on August 10, 2024 2

@valepu https://www.npmjs.com/package/is and https://www.npmjs.com/package/is_js are two entirely different libraries.

@shivam-tripathi Yes, but the types are for is_js despite being called @types/is.
I can confirm this because the function is.existy is available in "is_js" but not in "is". On top of that if you check the file https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/is/index.d.ts you can read the following

// Type definitions for is.js
// Project: http://arasatasaygin.github.io/is.js/
// Definitions by: Rodrigo Cabral <https://github.com/cabralRodrigo>, Mitchell Grice <https://github.com/gricey432>
// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped

from is.js.

valepu avatar valepu commented on August 10, 2024 1

There is a bit of a problem with the @types.
The DefinitelyTyped package for is_js seems to be @types/is (i have tried @types/is_js @types/is-js @types/is.js @types/isjs but they don't exist), and the method calls seem correct, but if i import it like this:

import * as is from 'is_js';

i get an error saying it can't find the type definition when building (despite VS code not giving me any error). if i import it like this

import * as is from 'is';

I get a different error. The solution seems to be to install is_js with an alias: "is": "npm:is_js@^0.9.0", and then import the module like this import * as is from 'is';

if i do like this it seems to work but maybe i'm doing something completely wrong

from is.js.

lancedolan avatar lancedolan commented on August 10, 2024 1

To illustrate that @valepu is correct and there is a mismatch here:

  1. navigate to https://www.npmjs.com/package/@types/is
  2. Read :

    This package contains type definitions for is.js (http://arasatasaygin.github.io/is.js/).

  3. navigate to http://arasatasaygin.github.io/is.js
  4. click "View On Github", navigates to https://github.com/arasatasaygin/is.js
  5. Notice that the package name used in the readme directions is is_js

from is.js.

lancedolan avatar lancedolan commented on August 10, 2024 1

Update: I discovered that @types/is exports their types for both modules is and is_js.

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/is/index.d.ts#L1377-L1383

That can't be right.

from is.js.

shivam-tripathi avatar shivam-tripathi commented on August 10, 2024

@valepu https://www.npmjs.com/package/is and https://www.npmjs.com/package/is_js are two entirely different libraries.

from is.js.

lancedolan avatar lancedolan commented on August 10, 2024

Well I buckled and switched from is_js to is purely for easy typescript support, though I preferred the is_js api.

Also type definitions in @types/is aren't typeguard-friendly. I believe should be (x:unknown) : x is string and not (x:unknown) : boolean. Might log issue in that repo.

from is.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.