Giter Club home page Giter Club logo

Comments (4)

rvanlaak avatar rvanlaak commented on June 13, 2024

IMHO resetting the trail by passing an emtpy breadcrumb is an hard to understand workaround that should be deprecated asap, and be removed v2 of this bundle.

Introducing an #[ResetBreadcrumbTrail] attribute would be a way more explicit solution.

Let me know what you think, and if you are able to help in introducing the annotation and deprecating the current behavior.

from apybreadcrumbtrailbundle.

phillamarmotte avatar phillamarmotte commented on June 13, 2024

I'm not sure creating a new annotation will be easier to use.
I would prefer the #[Breadcrum] attribute with a reset param.
#[Breadcrumb(reset: true)]

And of course i can help with that

from apybreadcrumbtrailbundle.

rvanlaak avatar rvanlaak commented on June 13, 2024

Not having the default value on title anymore is a BC break though, so will fix that on the v1.x branch.

Resetting the trail is an entirely different concern as adding a breadcrumb and parsing it's values. The code related to their behavior thereby should explicitly be splitted, which is not possible when such resetting behavior would get mixed with the existing #[Breadcrumb] attribute.

An example benefit, your IDE will allow you to easily find a project's usages of the ResetBreadcrumbTrail annotation.

from apybreadcrumbtrailbundle.

rvanlaak avatar rvanlaak commented on June 13, 2024

@phillamarmotte https://github.com/APY/APYBreadcrumbTrailBundle/releases/tag/v1.8.0 was tagged with a fix for the issue

from apybreadcrumbtrailbundle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.