Comments (4)
IMHO resetting the trail by passing an emtpy breadcrumb is an hard to understand workaround that should be deprecated asap, and be removed v2 of this bundle.
Introducing an #[ResetBreadcrumbTrail]
attribute would be a way more explicit solution.
Let me know what you think, and if you are able to help in introducing the annotation and deprecating the current behavior.
from apybreadcrumbtrailbundle.
I'm not sure creating a new annotation will be easier to use.
I would prefer the #[Breadcrum] attribute with a reset param.
#[Breadcrumb(reset: true)]
And of course i can help with that
from apybreadcrumbtrailbundle.
Not having the default value on title
anymore is a BC break though, so will fix that on the v1.x
branch.
Resetting the trail is an entirely different concern as adding a breadcrumb and parsing it's values. The code related to their behavior thereby should explicitly be splitted, which is not possible when such resetting behavior would get mixed with the existing #[Breadcrumb]
attribute.
An example benefit, your IDE will allow you to easily find a project's usages of the ResetBreadcrumbTrail
annotation.
from apybreadcrumbtrailbundle.
@phillamarmotte https://github.com/APY/APYBreadcrumbTrailBundle/releases/tag/v1.8.0 was tagged with a fix for the issue
from apybreadcrumbtrailbundle.
Related Issues (20)
- % sig in deprecation message breaks synfony on php8 HOT 2
- Deprecation notices (symfony 5.2.6 / deprecation-contracts 2.4.0) HOT 2
- Found unknown escape character "\B" HOT 1
- Page freeze HOT 2
- Overriding template in Symfony 5 HOT 3
- Trigger deprecations when using annotations
- add support for Rector annotation-to-attribute-migration HOT 8
- Update documentation to use PHP attributes instead of annotations
- Run Rector upgrade script as Composer plugin HOT 1
- Bug 1.7 #[Breadcrumb("{book.title}")] HOT 9
- PHP 8.1 deprecation warnings HOT 2
- Tag symfony 6.1 HOT 2
- Update symfony/deprecation-contracts? HOT 3
- Symfony 6.3 deprecation warnings HOT 1
- Working without sensio extra framework HOT 3
- Continue trail of another Route
- It is not compatible with Symfony 7.0 HOT 1
- Conversion from parameter to object not working as intended in Symfony 6.3
- Conversion from parameter to object not working as intended in Symfony 6.3 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from apybreadcrumbtrailbundle.