Comments (9)
Not adding additional root certificates breaks the app.
Adding additional root certificates to OS breaks the compiler .
from influxdb2.
I'm curious what is the motivation for this?
from influxdb2.
The motivation is to avoid breaking the rust compiler and your influxdb2 client.
Elaboration:
- Those new to influxdb2 may install influxdb2 OSS locally.
- At present, by design:
- IF/WHEN a self-signed CA has been added to the target: rust appears to emit an error and refuse to compile - At present, by design, your client:
- will not connect to the server, unless it trusts the server's CA
- will not accept addtional trusted root certificates to establish trust,
- meaning:
- If/WHEN the server's CA is self-signed, the CA needs to be installed on the target - breaking the compiler
- meaning:
- we have a conundrum - it is my recommendation that we resolve the conundrum as follows:
- add the ability to allow the client to accept additional certificates so that your client can increase it's "marketshare"
- At present, by design:
from influxdb2.
Anyone else having the same issue? I've never experienced this issue even when installing influxdb2 locally or using Docker.
When using Docker sometimes it shows the problem of not having the correct certificate but it can be solved by installing the SSL package.
from influxdb2.
Since installing a CA certificate is at the network level can't it be handled at the network level? Like by passing in the connection factory that first download the ca certificate.
Anyway this is suspect since I don't believe it should be handled at the library level since CA certificate should be handled at the network level. Pull request is welcome but no guarantee I'll accept it.
from influxdb2.
I have attached the proposed change above.
from influxdb2.
Yeah looking at the code, I believe this shouldn't be part of the Influxdb2 library because user is able to achieve the same thing by just instantiating a reqwest::Client
and creating an influxdb2::Client manually.
from influxdb2.
Can you please elaborate?
from influxdb2.
It sounds like you are saying fork the code base.
from influxdb2.
Related Issues (20)
- Why is the QueryResult new function src/api/query.rs in influxdb2 explicitly specifying lifetimes ? HOT 1
- Sum Aggregation function does not work as intended
- Compilation fails with serde 1.0.157 HOT 1
- Implement Raw Query Support
- Add cargo fmt check to build workflows
- Remove tracing `max_level` features
- Use secrecy crate's Secret object for wrapping the auth token
- panicked on query containing pivot in latest version HOT 1
- Improve performance by parsing directly into `struct` HOT 1
- Derive macro FromDataPoint not working for nested types? HOT 2
- Using influxdb2 crate in a non-async context HOT 2
- Exposing the underlying reqwest client to support custom mTLS certificates. HOT 4
- Allow zero-tag writing
- Strings aren't escaped properly in the derived `WriteDataPoint` HOT 1
- Value Enum inaccessible HOT 1
- `async fn query` should take a reference to a query, not the query instance itself HOT 3
- `Option` values in structs should exclude field in case of `None`, instead of being set to `"None"` HOT 1
- This crate should be imported using a one-liner in `Cargo.toml`
- Re-export reqwest?
- Support of unsigned integers `u64`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from influxdb2.