Switch to class-based views about django-rest-registration HOT 12 CLOSED

It would also be great if we could add them to a router, so that they be documented with the rest of the endpoint.

from django-rest-registration.

And please do update django rest framework dependency to latest.

This will be done in issue #70. Unfortunately it's not so simple as just bumping up the requirements.

from django-rest-registration.

BTW: there is already a lot to do for the 0.6.0 release, so I will aim with refactoring the views for release 0.7.0.

from django-rest-registration.

@peterthomassen
Sorry to respond so late. At first I didn't like this idea, as I think about Django View Classes as an uneccesary Javaification (aka "everything has to be a class"). On the other hand, I see this as a predominant pattern of extending the views in Django community, instead of function composability.
So it could definetely improve the extensibility in more advanced cases for average Django user. Therefore I decided that we should go for it, but in the next semi-major release (probably 0.6.0 as the current one is 0.5.0).

I think I would still leave the view functions, but they would be derived automatically from specific view class (which could be set in the settings dict - this way one does not have to fork the repository but he/she can replace specific view class in settings).

Do you agree?

from django-rest-registration.

yep, that sounds very good to me!

(I disagree on the Javaification argument. My point is not that it should be a class; that just happens to be the DRF way. My point really is that this approach offers a lot of ways to hook into the view execution flow.)

from django-rest-registration.

@jpic Could you explain what you mean by that? E.g. provide an example (snippet of code).

from django-rest-registration.

@apragacz Actually today i was working on a project and i thought using DRR with simplejwt. But what i found is all views are function based so to extending it and modifying is really hard(I don't know if there is any other ways by which i can achieve this). So what i suggest is using of generic views so that adaption process can be much smoother and safer for production ready web application. :)

from django-rest-registration.

And please do update django rest framework dependency to latest.

from django-rest-registration.

Change will be released in next (0.8) version

from django-rest-registration.

@apragacz , when will version 0.8 be released ?

from django-rest-registration.

@mdefeche I've just released it now

from django-rest-registration.

Thanks @apragacz :-)

from django-rest-registration.