Giter Club home page Giter Club logo

Comments (10)

kytrinyx avatar kytrinyx commented on June 30, 2024

I think you're right that the README could use more examples.

Could some of the test-cases be a basis for the examples?

from approvaltests.ruby.

markijbema avatar markijbema commented on June 30, 2024

Yes, I think that would work pretty well :) Also the CLI should be documented (I was totally surprised that that existed ;) ).

from approvaltests.ruby.

kytrinyx avatar kytrinyx commented on June 30, 2024

Yes, good call!

from approvaltests.ruby.

markijbema avatar markijbema commented on June 30, 2024

Wondered about this today, but any reason for not following -i/-f semantics? I'd say -i should do -ask true, -f should do -ask false, and the default is up to you.

from approvaltests.ruby.

kytrinyx avatar kytrinyx commented on June 30, 2024

Is that --interactive and --force? How is --force the same as "don't ask, do nothing"?

from approvaltests.ruby.

markijbema avatar markijbema commented on June 30, 2024

Ah sorry, I didn't read the updated readme yet. You're right of course. In that case --force is the option I'm missing ;)

from approvaltests.ruby.

markijbema avatar markijbema commented on June 30, 2024

Actually, now I think about it, 'verify --ask false' is a strange name for 'diff'. When you call verify with ask I'd say you're not really verifying. What about

  • approvals diff == approvals verify --ask false
  • approvals verify == approvals verify --ask true
  • approvals verify -f == echo -e "y\ny\ny\n" | approvals verify --ask true

I might be missing something though, because I only use the default verifyer, and not the vimdiff, but I expect this would work the same in that case right?

(on a sidenote, any reason you use -a in your vim-mapping? That's the default, right?)

from approvaltests.ruby.

kytrinyx avatar kytrinyx commented on June 30, 2024

Actually, now I think about it, 'verify --ask false' is a strange name for 'diff'.

Yeah that's fair, but I don't like the syntax:

$ approvals diff --diff vimdiff

I agree that if we have an approvals diff that never asks, it makes sense to have approvals verify that always asks.

As for the third suggestion, I can imagine a use case where you would want to automatically accept the new output.

(on a sidenote, any reason you use -a in your vim-mapping? That's the default, right?)

I think what I originally intended was a flag that is true if present, false if absent. Looking at it again, I totally screwed that up.

from approvaltests.ruby.

markijbema avatar markijbema commented on June 30, 2024

approvals view?

from approvaltests.ruby.

kytrinyx avatar kytrinyx commented on June 30, 2024

Oooh, I like that!

from approvaltests.ruby.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.