Comments (2)
I think we absolutely can change this, as the removal of nghttp2 will be a semver major anyway.
The question is what the design should be. My inclination is to avoid a Frame protocol with subtypes, as it necessarily involves a lot of type casting with the runtime performance overhead that entails.
Iām somewhat more interested in the possibility of using an enumeration with an escape hatch for future custom frame types. This would be a .custom
case that holds both the frame ID and an Any
, allowing a hook for extensions in the future.
That said Iām definitely open to other designs.
from swift-nio-http2.
Not sure if it matters but we use unkown
in netty for custom frame types.
from swift-nio-http2.
Related Issues (20)
- DataBuffer.evacuatePendingWrites allocates unnecessarily
- HPACKHeaders.peekPseudoHeader allocates awkward temporary array
- HTTP2ChannelHandler.wroteFrame is never returned to false
- Consider returning [Substring] from HPACKHeaders.subscript(canonicalForm:)
- Provide API for adding pseudo headers to HPACKHeaders
- OutboundFlowControlBuffer probably allocates unnecessarily
- Suport HTTP Protocol Upgrade Mechanism HOT 7
- Improve performance of `Substring._trimWhitespace()` HOT 1
- Suppress writes triggered by EOF reads
- Remote pushes with invalid headers leave a stream dangling
- Push latest versions to CocoaPods? HOT 1
- `NIOHTTP2Handler` should handle `ChannelShouldQuiesceEvent` HOT 2
- Reconsider implementation of Equatable and Hashable for HPACKHeaders HOT 2
- Remove @unchecked Sendable when NIOCore adopts Sendable
- Produce a better error when sending HEADERS on a quiesced connection
- StreamMap slow? HOT 7
- Failed assertion in change from 1.24.1 to 1.25.0 HOT 5
- The new HPACK header test for RemoveAll() fails on Android HOT 2
- Race condition causes header frame to be fired on HTTP2StreamChannel AFTER first data frame(s) HOT 3
- Content-Length in responses on HEAD method produce error HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
š Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ššš
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ā¤ļø Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from swift-nio-http2.