HTTPS Connection hangs when using Connect-Proxy with Android Emulator about swift-nio-examples HOT 10 CLOSED

So, I investigate further by writing a dead simple Proxy by NodeJS.

It turns out, connect-proxy returns the Content-Length: 0 in the HTTP/1.1 200 OK message (code), so Android Emulator doesn't work 🤔

cURL or modern network client (URLSession, Web browsers) works fine, but not Android Emulator.

For example: cURL ignores it.

< HTTP/1.1 200 Connection Established
< Content-Length: 0
* Ignoring Content-Length in CONNECT 200 response

Question:

1. Is it possible to completely remove the Content-Length: 0 or Transfer-Encoding: chunked ? I just want to return the simple message HTTP/1.1 200 OK from the CONNECT request.

from swift-nio-examples.

Yeah, good catch. Right now NIO doesn't support doing that, but it should. It's a somewhat complex patch to write though. Let me see if I can throw it together.

from swift-nio-examples.

Thanks. I finally write a patched version of HTTPResponseEncoder. It removed the Content-Length, and Transfer-Encoding logic. In the end, It fixes the bug.

Not sure if there are any unseen problems? 🤔

from swift-nio-examples.

The problems are in the general use-case: it isn't safe for us to unconditionally omit them, because users rely on our behaviour of inserting them. The trick is that we only want to skip that logic for responses to CONNECT requests. Fortunately, I believe we have the hooks we need to do this.

from swift-nio-examples.

Oof, actually it's quite hard to do it nicely. I think we need to add configuration to the encoders to enable you to opt-out of them modifying the framing headers.

from swift-nio-examples.

Thanks. I will keep on eyes on it, and report if it has any problems on production build 👍

from swift-nio-examples.

See apple/swift-nio#2508.

from swift-nio-examples.

I just merged that patch to main, want to try to use it?

from swift-nio-examples.

Thanks so much for your work @Lukasa I'm going to try it now 👍

from swift-nio-examples.

It works as intended. I'm happy to close this ticket 🙇

from swift-nio-examples.