Issue setting different levels on log handlers in a MultiplexLogHandler about swift-log HOT 5 CLOSED

Ah, disregard the last message, sorry! I am seeing now in the code change that that will respect the multiple log levels 😃.

from swift-log.

Interesting catch, thanks for reporting!

So this is a weird interaction between how the Logger decides if it should dispatch to the underlying handler or not, it does so by:

        if self.logLevel <= level {
            self.handler.log(level: level, ...

and the multiplex handler naively implements logLevel as:

    public var logLevel: Logger.Level {
        get {
            return self.handlers[0].logLevel

so that's going to yield surprising behaviors as you just noticed.

I think we should be setting the loglevel to the "lowest of any passed in loggers" I suppose.

I'll give this a look since I have a moment now, thanks :-)

from swift-log.

Thanks @ktoso ! I just read over the PR comments and that discussion is really great. It seems like a valid workaround for now would be to just reorder the handlers that are being passed into the multiplex handler?

from swift-log.

Correct yes, until we land that PR and the behavior changes that's what is documented and the behavior -- so yeah, you can put the "lowest" log level one first and that should work :)

from swift-log.

Thanks for the quick reply!

I think maybe I have misunderstood some of that conversation on the PR, but now, by switching the order of the two loggers, trace messages are still getting sent to MyLogger which has its log level set to info. Is that still expected?

from swift-log.