Giter Club home page Giter Club logo

Comments (12)

MaxDesiatov avatar MaxDesiatov commented on August 16, 2024

What are you looking for in GitHub releases specifically that you don't get from tags? Each snapshot and released version of Swift have corresponding tags on corelibs repositories, including libdispatch: https://github.com/apple/swift-corelibs-libdispatch/tags

from swift-corelibs-libdispatch.

hmelder avatar hmelder commented on August 16, 2024

Yes but synchronisation becomes challenging when no release is created with the specific tag. Is it possible to also create a release along the way?

from swift-corelibs-libdispatch.

MaxDesiatov avatar MaxDesiatov commented on August 16, 2024

Yes but synchronisation becomes challenging when no release is created with the specific tag.

Can you elaborate on this? What synchronization are you referring to? What exactly do you find challenging?

from swift-corelibs-libdispatch.

hmelder avatar hmelder commented on August 16, 2024

Suppose I want to package libdispatch for a distribution like NixOS, or Debian. When sourcing from GitHub, the tooling leverages GH release information and notifies the maintainer about a new release. Just working with tags is possible, but inconvenient.

Other tooling might use the latest release tag from the repository which in this case is incorrect (stuck at 5.5).

The solution would be to either fetch the release tag from https://github.com/apple/swift and hope that it is also present in this repository (I guess you are synchronising tags across subprojects), or hardcode a release tag, and periodically check for new releases.

A tag marked as release would greatly simplify this process.

from swift-corelibs-libdispatch.

MaxDesiatov avatar MaxDesiatov commented on August 16, 2024

Just working with tags is possible, but inconvenient.

Would you be able to clarify what exactly is inconvenient? AFAIK we didn't post release notes or changelog snippets in those GitHub releases that were posted (by accident I assume), so compared to tags creating new GitHub releases is just a duplication of work.

Other tooling might use the latest release tag from the repository which in this case is incorrect (stuck at 5.5).

IMO such tooling should be changed to rely on tags instead.

A tag marked as release would greatly simplify this process.

Tags that are actual releases are already marked with the -RELEASE suffix. Would filtering by that suffix resolve your issue?

from swift-corelibs-libdispatch.

hmelder avatar hmelder commented on August 16, 2024

IMO such tooling should be changed to rely on tags instead.

So fetching all tags from the repository and filtering based on the way the tag is structured, and picking the latest one? This is one of the reason why releases exist in the first place: Providing a unified way of accessing the latest release tag (A gh release is nothing else then a referenced tag with some metadata and tarball). You could even use existing tags for the release or automate it.

My point is that every project that there should be a way to get the latest *-RELEASE tag. Can you point me to the section where I can find the tag?

from swift-corelibs-libdispatch.

hmelder avatar hmelder commented on August 16, 2024

I guess the RELEASE tags are hidden behind all the snapshot tags

from swift-corelibs-libdispatch.

MaxDesiatov avatar MaxDesiatov commented on August 16, 2024

A gh release is nothing else then a referenced tag with some metadata and tarball). You could even use existing tags for the release or automate it.

Tags on GitHub provide tarballs too. As I said, GitHub releases that were posted on some Swift repositories weren't a coordinated effort and most if not all of them didn't contain any release notes, so no additional metadata either. They were basically a duplication of some tags.

I don't think there's a need to automate creation of something that duplicates information that already exists in the form of tags.

My point is that every project that there should be a way to get the latest *-RELEASE tag. Can you point me to the section where I can find the tag?

Sure, feel free to run this in a clone of any of the relevant Swift repositories.

git tag | grep RELEASE | sort -r

If you need to get the list of tags without cloning, there's an API call for that: https://docs.github.com/en/rest/repos/repos?apiVersion=2022-11-28#list-repository-tags

from swift-corelibs-libdispatch.

hmelder avatar hmelder commented on August 16, 2024

Is it possible to delete the existing tags or have an entry in the README to avoid confusion if you are reluctant to releases?

from swift-corelibs-libdispatch.

MaxDesiatov avatar MaxDesiatov commented on August 16, 2024

Is it possible to delete the existing tags or have an entry in the README to avoid confusion if you are reluctant to releases?

I assume you meant deleting existing releases? Deleting tags would be out of question, since tags are the single source of truth.

If you mean deleting existing releases for consistency to always rely on tags instead, I'd like to ask @shahmishal first to clarify if this is something we should do at some point.

In the meantime IMO you should rely on tags in our repositories and not assume that releases contain any additional information.

from swift-corelibs-libdispatch.

hmelder avatar hmelder commented on August 16, 2024

I mean the releases, sorry.

from swift-corelibs-libdispatch.

hmelder avatar hmelder commented on August 16, 2024

In the meantime IMO you should rely on tags in our repositories and not assume that releases contain any additional information.

Yes, but since there are also releases this is confusing for people not familiar with the matter.

from swift-corelibs-libdispatch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.