Comments (8)
Fixed in #8623
from llvm-project.
cc @chelcassanova, I'll look into resolving this soon and would love to hear your thoughts before digging in!
from llvm-project.
Hey Jeremy, thanks for tagging me in this and also for the patch! The "Setting up Swift reflection" report is indeed missing a total and your patch is correct, if you're able to put that patch up for review and add me as a reviewer that would be great 👍🏾 .
For the "Importing Swift modules" report, we actually have that as an indeterminate report so it doesn't have a total. The multiple reports you're seeing for "Importing Swift modules" is a bug that I'm looking into, thanks again for bringing this up!
from llvm-project.
I appreciate you looking into this @chelcassanova! PR with the aforementioned patch is up here #8584
(I don't think I have the right repo privileges to manually specify reviewers)
from llvm-project.
I finally got around to updating my Swift toolchain to a version which includes #8623, but I'm still seeing these persistent notifications when debugging a Swift project in VS Code:
If I understand the Progress
semantics correctly, completion is only signaled upon one of:
- if a total was set in the constructor, when
Increment
reaches that total Progress
object destructor is run
If we don't know the number of modules up front, is there a way to clean up the Progress
object once we've completed?
from llvm-project.
Hey Jeremy, so sorry for my late response and thanks for looking into this! The Progress
destructor should get run once the object is out of scope due to RAII, and since we create the progress report for Swift imports through a callback we also clear that callback on scope exit.
One of the original reasons that those spurious reports were coming in was because we cleared the callback by creating a new Progress
object which will print the message it was initialized with, so the patch I merged just cleared it to an empty function. Just curious, are all of those reports just showing up with a title and no details?
from llvm-project.
Just curious, are all of those reports just showing up with a title and no details?
Yes, as far as I can tell. Here's a screenshot from just now:
swift --version
reports compnerd.org Swift version 6.0-dev (LLVM 57177aa1b91540b, Swift 6debc331289f02d)
, and this includes #8623 (https://github.com/apple/llvm-project/commits/57177aa1b91540b).
I let this spin for quite a bit (10+ minutes) and never saw them go away, so I assume that the std::unique_ptr<Progress>
is being kept alive somehow, though I haven't confirmed this.
More than happy to provide as much detail as I can on this!
from llvm-project.
The unique_ptr
staying alive is also one of the main culprits I can think of, the other being that the reports are getting created but no details are being displayed which would indicate that the message that's supposed to get displayed with progress->Increment
isn't being displayed at all, or that these reports are created but progress->Increment
itself isn't being called so no details are added to the report. 🤔
from llvm-project.
Related Issues (20)
- Infinite recursion in ParseTrieEntries when parsing libGPUCompilerUtils.dylib HOT 1
- Apple Clang: std::source_location returns a wrong result if called in a function parameter.
- xros and visionos compilation support? HOT 4
- Module not found diagnostics are repeated multiply
- Compiler crash while serializing `std::optional` HOT 1
- A request to Apple to open-source the Metal Shading Language compiler
- [CI] apple-llvm-project-PR-windows fails to checkout `release/5.10`
- Usage of RemoteCachingService?
- CAS Unittests broken on Windows HOT 1
- `-finstrument-functions` linking error on Apple clang
- [IR lower bug] Apple's clang generated code will not abort when empty std::string call pop_back(), while llvm/clang do
- Compiler crash on Windows with `-index-store-path` HOT 1
- Compilation fails on Amazon Linux 2023 aarch64 HOT 1
- Doc Comments Are Ignored for Macros HOT 3
- DAP support
- Apple fork clang++ regression in partial specialization templates for hasher
- [HELP]what's the exactly command to build Xcode toolchain from this apple repo? HOT 1
- Clang crash: Idx < Size && "access in bound" in AssignmentTrackingAnalysis HOT 5
- Add support for <bit>
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from llvm-project.