[SR-77] In the repl, auto-indent overwrites text about llvm-project HOT 4 CLOSED

Comment by Kate Stone (JIRA)

Similar issues in the past have been attributed to subtle issues with the editline implementation provided by libedit on different distributions. The supported distributions should come with compliant implementations by default.

If you'd like to dig further, what's happening here is that the REPL knows that : is one of the characters that might require changing the indentation level of the current line (another case is the closing brace.) The code that actually does the indentation work is in LLDB's source/Host/common/Editline.cpp, in the method Editline::FixIndentationCommand (int ch)

from llvm-project.

Comment by Kate Stone (JIRA)

After some thought, I've assigned the issue to me since I wrote the code originally and believe I have a reasonable strategy for making this code path less fragile in the presence of different editline implementations.

from llvm-project.

Comment by Kate Stone (JIRA)

Proposed fix in apple/swift-lldb#1

from llvm-project.

Comment by Kate Stone (JIRA)

This change landed over in llvm.org and I've cherry-picked it to Github. It should land in the next stable binary drop, or it can be built from current sources – either way I'd appreciate confirmation that this change works as expected on the distribution where this was originally reported.

from llvm-project.