attr version range about kms-encryption-toolbox HOT 7 CLOSED

@billcrook Thanks, can you also provide which version of attr you've been using when this error occurred?

from kms-encryption-toolbox.

Looks like this is a transitive dependency resolution conflict with pytest. In the pytest FixtureFunctionMarker class[1], they use the attr.converters.optional[2], which was introduced in 17.1.0.

As an FYI, aws-encryption-sdk will be bumping the minimum attrs version to 17.4.0 in the next release[3]. Is there a specific reason you capped attrs at 17.0.0?

[1] https://github.com/pytest-dev/pytest/blob/db4df5833a6699345761e1851bfed32eb1109121/_pytest/fixtures.py#L844
[2] https://github.com/python-attrs/attrs/blob/master/src/attr/converters.py#L8
[3] aws/aws-encryption-sdk-python#40

from kms-encryption-toolbox.

I'll try to look into it this week. Thanks for the tip!

from kms-encryption-toolbox.

@lukaszb 17.4.0

from kms-encryption-toolbox.

I'm actually not seeing attrs used anywhere in your codebase. Was this dependency block to work around the issues aws-encryption-sdk had with attrs 17.0.0? If so, we fixed that in 1.3.0 (and isolated the attrs dependency ourselves in 1.2.2).

https://github.com/awslabs/aws-encryption-sdk-python/blob/master/CHANGELOG.rst#122
https://github.com/awslabs/aws-encryption-sdk-python/blob/master/CHANGELOG.rst#130

from kms-encryption-toolbox.

@mattsb42-aws yes, exactly that. We removed the direct dependency and published a new version: https://pypi.python.org/pypi/kms-encryption-toolbox/0.1.0

from kms-encryption-toolbox.

Great! If you ever run into something like that again before we notice it, please let us know with an issue in our repo and we'll make sure it is addressed asap (PRs are also welcome).

from kms-encryption-toolbox.