Giter Club home page Giter Club logo

finder's People

Contributors

debloper avatar dolftax avatar indus avatar kaustavdm avatar kumarrishav avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

finder's Issues

[1.1] debugMode is enabled in production

Forgot to turn off debug mode in 1.1. Now everything is getting logged in the console. And the app can feel to be slow. Need to push out an early release with debugMode turned off.

Add preferences for searching through hidden files

In the "About" view, add a "Preferences" section that will have an option to search through hidden files.

This will be a checkbox. The value of it will be persisted through localStorage. Default value should be disabled. The value should be checked on startup.

This option will change the value of Applait.Finder.checkhidden.

Refactor code added to fix #5

We have several blocks of repeating code which came in from the 2 PRs made to solve #5. They are in js/ui/home.js and js/ui/actions.js and toggle the disabled state of the search interaction elements.

These blocks should ideally move to functions and those functions should be called from event listeners.

Improve touch UI feedback on buttons

As of now we have a :focus declaration for buttons, but that does not work well with touch screens.

Need to apply the same animation to buttons when they are tapped on touchscreens. This would mean using touch events. instead of just click events, and using JavaScript instead of CSS :focus to detect those events and use a class to do the animation.

Essentially, the :focus events need to be there, but we also need better touch events for buttons.

Fix flexbox rendering on older versions of Firefox OS (1.1 and 1.2)

As of now we say that Finder is supported only on Firefox OS 1.3+. The reason is, pre-1.3 did not have support for the standard display: flex. We have to use -moz vendor prefixes to make sure the current layout works in Firefox 1.1+.

Any place in the CSS where we are using flexbox need to be supplemented with the vendor prefixes. After that we can say that Finder is supported on Firefox OS 1.1+.

Use `data-goto` on a single parent element for seach result list items

In home view, the searchresult item template uses data-goto on each child item to detect click. That was a quick patch to make sure it works, but it is not a good solution. As of now, in index.html it looks like:

<!-- searchresult item -->
<template id="tmpl-searchresult-item">
    <div id="searchresult-item-{i}" class="searchresult-item" data-index="{i}" data-goto="#/detail/{i}">
        <button data-goto="#/detail/{i}">
            <i class="icon-{icontype}"></i>
        </button>
        <h3 data-goto="#/detail/{i}">{name}</h3>
        <button data-goto="#/detail/{i}">
            <i class="icon-right-open"></i>
        </button>
    </div>
</template>

Ideally, only .searchresult-item elements should have the data-goto attribute. That should work whenever a single .searchresult-item item is tapped.

Add preferences for turning on debugMode

In the "About" view, add a "Preferences" section that will have an option to enable debugMode.

This will be a checkbox. The value of it will be persisted through localStorage. Default value should be disabled. The value should be checked on startup.

This option will change the value of Applait.Finder.debugmode.

Add preferences for making searches case-sensitive

In the "About" view, add a "Preferences" section that will have an option to make searches case-sensitive.

This will be a checkbox. The value of it will be persisted through localStorage. Default value should be disabled. The value should be checked on startup.

This option will change the value of Applait.Finder.casesensitive.

Disable reset button, search form and search button when search is going on

We forgot to disable reset button and search form and search button when search is going on. As a result, if anyone hits the reset button while a search is being continued, it will result in broken UX.

These elements should be disabled on api.finder.on("searchBegin", fn) and enabled on either of:

  • api.finder.on("searchComplete", fn)
  • api.finder.on("searchCancelled", fn)
  • api.finder.on("empty", fn)
  • api.finder.on("error", fn)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.