Giter Club home page Giter Club logo

Comments (14)

jlipps avatar jlipps commented on July 29, 2024 1

OK. I will try to upgrade wdio in w2d. Last time I tried there was some new internal dependency on Node.js that made it impossible.

from appium-inspector.

jlipps avatar jlipps commented on July 29, 2024 1

Well, it required adding a whole different request library to webdriverio for web, then it was able to be bundled and we could update w2d.

from appium-inspector.

KazuCocoa avatar KazuCocoa commented on July 29, 2024

Worked with disabling restrict ssl.
https://github.com/webdriverio/webdriverio/blob/e34108325ef1e0d2b8e2306fe407b5d934169777/packages/webdriver/src/request.ts#L123

It seems Electron's process.env is not the webdriverio's process.env...
So, we probably should give the flag over arguments, or we should find a way to give Electron's process.env to them.


Probably give strictSSL option to Web2Driver.attachToSession or Web2Driver.remote as serverOpts

from appium-inspector.

KazuCocoa avatar KazuCocoa commented on July 29, 2024

note: fixing this issue now.

https://github.com/webdriverio/webdriverio/compare/master...KazuCocoa:add-strictssl-as-options?expand=1
This may fix this issue to set strictSSL false on Electron apps

from appium-inspector.

KazuCocoa avatar KazuCocoa commented on July 29, 2024

Created a PR to webdriverio. Once the option will be available, then this blocking issue will be resolved.

Then, we can push a new beta to share this with other vendors to check their features after web2driver update and view splitting.

from appium-inspector.

jlipps avatar jlipps commented on July 29, 2024

what's the status here? do we need to update w2d with latest wdio changes?

from appium-inspector.

KazuCocoa avatar KazuCocoa commented on July 29, 2024

Yes, we need a newer webdriverio which has webdriverio/webdriverio#6134 to give SSL option for Electron environment.
Or if we can find a way to set environment variables for libraries on Electron environment, it will be an alternative. process.env in Electron environment was different in main modules and libraries when I dug it int before. (So needed such option)

from appium-inspector.

KazuCocoa avatar KazuCocoa commented on July 29, 2024

πŸ‘
thanks

from appium-inspector.

jlipps avatar jlipps commented on July 29, 2024

well, i tried to update webpack and got lost in a black hole of things not working. still gonna keep working on this but can't do it immediately

from appium-inspector.

KazuCocoa avatar KazuCocoa commented on July 29, 2024

Do you think if we can fork webdriverio to our appium repository, add the webdriverio/webdriverio#6134 in the fork, and build the fork as part of web2driver as a tentative solution for this inspector?

from appium-inspector.

jlipps avatar jlipps commented on July 29, 2024

It could be. The issues I'm having right now are related to Webpack though and not WDIO. So once I get bundling straightened out I may be able to simply pull the latest WDIO and have it work. We'll see.

from appium-inspector.

jlipps avatar jlipps commented on July 29, 2024

@KazuCocoa can you re-check to see if this issue still persists with all the recent changes?

from appium-inspector.

KazuCocoa avatar KazuCocoa commented on July 29, 2024

ok, will check

from appium-inspector.

KazuCocoa avatar KazuCocoa commented on July 29, 2024

Yes, 2021.8.5 no longer has this issue. πŸŽ‰
So, webpack update fixed this...? (To up to date the webdriverio)

from appium-inspector.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.