Giter Club home page Giter Club logo

Comments (10)

krispenney avatar krispenney commented on September 16, 2024

Could I take this one?

from react-components.

vikasrohit avatar vikasrohit commented on September 16, 2024

You are all set. Go ahead. 👍

from react-components.

vikasrohit avatar vikasrohit commented on September 16, 2024

@K9101 You can check Panel example in the dev branch for reference.

from react-components.

krispenney avatar krispenney commented on September 16, 2024

Ok thanks!
If the icon is on the left or right, should the text and image remain on their respective edges while the item fills it's container (like the panel)?

from react-components.

vikasrohit avatar vikasrohit commented on September 16, 2024

@K9101 Sorry, for any confusion, however, the icon and the image are the same. We are calling the image as icon. Now the three layouts (while naming the layouts, I have used text a base to decide the direction) would be like this:

a) dtu (down to up)

|------icon-------|
|------text------- |

b) rtl (right to left)

| icon | text ------------------------|

c) ltr (left to right)

| text ------------------------| icon |

from react-components.

krispenney avatar krispenney commented on September 16, 2024

@vikasrohit Thanks, that makes sense.
I just created a pull request for this issue, let me know if you would like any changes.

from react-components.

vikasrohit avatar vikasrohit commented on September 16, 2024

Thanks @K9101 I will review it in couple of hours. Meanwhile you can pick other one from available tasks.

from react-components.

vikasrohit avatar vikasrohit commented on September 16, 2024

@K9101 Can you please adhere to ES6 coding style as suggested by React documentation. For reference, please see the updated Panel component in dev branch.

from react-components.

krispenney avatar krispenney commented on September 16, 2024

@vikasrohit sorry for the delay, I just created a pull request with those changes.

from react-components.

vikasrohit avatar vikasrohit commented on September 16, 2024

Closing task. Thanks @K9101 for your hard work.

from react-components.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.