Comments (10)
Could I take this one?
from react-components.
You are all set. Go ahead. 👍
from react-components.
@K9101 You can check Panel example in the dev branch for reference.
from react-components.
Ok thanks!
If the icon is on the left or right, should the text and image remain on their respective edges while the item fills it's container (like the panel)?
from react-components.
@K9101 Sorry, for any confusion, however, the icon and the image are the same. We are calling the image as icon. Now the three layouts (while naming the layouts, I have used text a base to decide the direction) would be like this:
a) dtu (down to up)
|------icon-------|
|------text------- |
b) rtl (right to left)
| icon | text ------------------------|
c) ltr (left to right)
| text ------------------------| icon |
from react-components.
@vikasrohit Thanks, that makes sense.
I just created a pull request for this issue, let me know if you would like any changes.
from react-components.
Thanks @K9101 I will review it in couple of hours. Meanwhile you can pick other one from available tasks.
from react-components.
@K9101 Can you please adhere to ES6 coding style as suggested by React documentation. For reference, please see the updated Panel component in dev branch.
from react-components.
@vikasrohit sorry for the delay, I just created a pull request with those changes.
from react-components.
Closing task. Thanks @K9101 for your hard work.
from react-components.
Related Issues (20)
- Tooltip || Fix the tooltip rendering with one of parent being relatively positioned
- Tooltip || Fix CSS conflict coming from Dropdown component
- Display title for options of the SelectDropdown
- Remove console errors
- Update Travis CI configuration to allow use of version for components
- Support specific type for input text HOT 1
- Support column layout for RadioGroup component
- Support Dropdown form component
- Validation error for custom validation is not working HOT 1
- Warning: Formsy: isMounted is deprecated. Instead, make sure to clean up subscriptions and pending requests in componentWillUnmount to prevent memory leaks. HOT 4
- Warning: Unknown prop `'data-cap'` on <path> tag HOT 2
- TCFormFields.TextInput doesn't update default value from updated prop
- Fix lint HOT 1
- TiledRadioGroup component malfunction for multipleOptions is set false HOT 1
- New form component for skill suggestions HOT 11
- Slider component for Connect project form HOT 1
- isRequired validator doesn't support numeric values HOT 3
- [$75] React Tooltip - Allow the tooltip to persist if mouse is moved out to tooltip itself HOT 1
- MenuNav should use Link component and not anchor tag directly HOT 5
- Tabs Component
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-components.