Giter Club home page Giter Club logo

Comments (12)

probonopd avatar probonopd commented on June 18, 2024

Relevant code is here so it would be easy to comment out /opt in your own builds, but no, there is no blacklist mechanism yet. PR would be appreciated though.

from appimaged.

TheAssassin avatar TheAssassin commented on June 18, 2024

Blacklisting doesn't solve the problems of the world. I don't see the reason to monitor /opt anyway. How often is this directory used for AppImages? I think we can just get rid of it completely.

from appimaged.

tresf avatar tresf commented on June 18, 2024

There is no blacklist mechanism yet.

It appears inotifytools_watch_recursively would have to be replaced with inotifytools_watch_recursively_with_exclude.

from appimaged.

probonopd avatar probonopd commented on June 18, 2024

Yes, inotifytools_watch_recursively_with_exclude looks like it @tresf.
/opt is a good option imho for system-wide AppImages, @TheAssassin.

from appimaged.

probonopd avatar probonopd commented on June 18, 2024

@tresf I would be happy to accept a PR

from appimaged.

tresf avatar tresf commented on June 18, 2024

@tresf I would be happy to accept a PR

Apparently, inotifytools_watch_recursively_with_exclude assumes the exclude list is a listing of valid directories and the original bug report is a request to blacklist a directory pattern. This makes the request not possible with the built-in tools unless the utility first built this list dynamically at runtime based on some pattern searching, which is gross.

I'm afraid this may be a wontfix feature and just turn into a verbosity preference. The tool doesn't treat this folder incorrectly and there are hundreds (thousands?) of other commonly installed /opt locations that too would recurse into this location.

from appimaged.

TheAssassin avatar TheAssassin commented on June 18, 2024

@tresf one can always create a separate file for these kinds of features. You are hereby invited to send in a patch as proposal, we can then discuss the details.

from appimaged.

tresf avatar tresf commented on June 18, 2024

I'm not a stakeholder in this feature, it was simply a cosmetic observation while debugging #430. I won't be working on this.

from appimaged.

TheAssassin avatar TheAssassin commented on June 18, 2024

All right, thanks for the suggestion then, I'll leave this open as a feature proposal.

from appimaged.

azubieta avatar azubieta commented on June 18, 2024

Please transfer to the appimaged repo.

from appimaged.

TheAssassin avatar TheAssassin commented on June 18, 2024

You can send me a list of links of stuff to move via IRC, too, that won't generate as much spam.

from appimaged.

probonopd avatar probonopd commented on June 18, 2024

We should follow #30, "What triggers system integration".

from appimaged.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.