Giter Club home page Giter Club logo

Comments (4)

e0da avatar e0da commented on July 28, 2024

So I think we should just add a variable parameter to the rake task. When we do rake test, we can do

rake test TEST=path/to/my_test.rb TESTOPTS='--name=test_a_feature'

So I'm thinking we could add something so you can do

rake eslint:run ESLINTOPTS='--cached'

The only downside I see is that we probably should not mirror this capability in the web interface because I haven't thought of a good way to do it yet. Also, maybe people don't use the web interface?

from eslint-rails.

DLvalentine avatar DLvalentine commented on July 28, 2024

I certainly love the web interface when I am manually fixing warnings/errors by hand. It helps a lot, and reduces the strain of having to read terminal output, which isn't always pretty.

I do wish there was an easier way to provide flags, and think it is critical considering eslint can attempt to auto correct issues with the --fix flag. Rubocop has an excellent way of handling flags like that, and I would very much like to see this be a thing with eslint-rails.

from eslint-rails.

DLvalentine avatar DLvalentine commented on July 28, 2024

I will consider taking a look at this perhaps contributing in order to make this a reality 😎🤔🍻

from eslint-rails.

DLvalentine avatar DLvalentine commented on July 28, 2024

So I forked this repo and wrote in code to allow for auto-correction, as well as a few more goodies. Seeing as this repo isn't really being actively maintained, I will keep the fork separate unless it is desired that they be merged.

New features include

  1. updated readme
  2. updated eslint
  3. autocorrection feature
  4. different exit statuses based on eslint.json settings. If you have a rule set to error, the build will exit 1. If it is set to warning and no errors exist, it will exit 0
  5. updated the controller to not break if you don't provide force_deafult
  6. updated the web interface to allow you to use autocorrect, or not
  7. updated the rake tasks
  8. updated the before_filter to be before_action, since the former was deprecated

I'll be continuing my own support for this in my free time, and intend to include many more features and improvements :)

from eslint-rails.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.