Coding standards and PEP8 about appdaemon HOT 4 CLOSED

No problem. I can wait for the next release. I've been able to identify some issues with the code besides formatting. For example you shouldn't check if something is False or True using equality operation (==) but you should use is keyword (if foo is False for example). I'll try to find such issues and also correct them.

from appdaemon.

Not sure that I agree it's hard to read, but I am relatively new to Python and haven't been exposed to PEP8, so I guess if you are used to that format it could be challenging - if you are happy to reformat I am happy to take it as a PR and accept it as a learning process and maintain it going forward :)

If you do decide to go ahead can I ask that you submit the PR after the next major release - I am gettingready to release 1,5.0 and it has quite a few changes. Rather than merge I would prefer you submit against that version as it should be the last for a while. I am planning to release it at the weekend.

from appdaemon.

Andrew, I've also noticed this but for what it's worth, I've never had a problem understanding your logic. I'm self-taught Python over the past few years, and it's a bit obvious you didn't start with Python as a cs lang, but that's totally fine. @yawor thanks for taking on this endeavor!

from appdaemon.

1.5.1 is now live. I'll close this and await the PR - thanks!

from appdaemon.