Cascade cache remove loops forever on cyclic references about apollo-kotlin HOT 11 OPEN

Yes I missed that, you're right the entries should be removed from the journal and lruCache in the memory cache. For some reason the process gets stuck though. I will investigate more and maybe setup a reproduction.

from apollo-kotlin.

Okay I think I got it. The problem is in the SQL cache (I have the memory cache chained to SQL)

Here is the offending method:

It keeps trying to delete children before itself and thus create a loop.

from apollo-kotlin.

Sure, I'll see when I'll get to it though :)

from apollo-kotlin.

Thanks for sending this 🙏 Do you have a reproducer by any chance? The remove() call there should be mostly idempotent so calling it multiple times with the same cache key should be harmless I think (recordJournal should be null the 2nd time). But there could very well be something else. I'll keep digging but a reproducer would help a ton.

from apollo-kotlin.

Excelent catch! Do you want to submit a fix?

• load all referenced ids
• delete record
• delete each referenced id. If any is self referential, the fact that it's now deleted should break the cycle.

from apollo-kotlin.