Parity with Apollo Kotlin: Ability to Observe ApolloStore Changes? about apollo-ios HOT 3 CLOSED

Thanks for the request and all the details. It really helped me to have the references to the past discussions!

I'm very open to doing this at this time. The discussion about subscribers being strongly retained in #2300 just means that we need some documentation around this that indicates that a subscriber needs to be unsubscribed from the store before you let it go out of scope or it will be retained. There are plenty of easy ways to ensure that you're doing that, and this is more of an advanced API, so I'm okay with just requiring users to be responsible for that.

In the future, I'd love to improve on this API and make it harder to create retain cycles there, but for now, I think it's fine to just document it.

I'd be happy to get this out for our next release. But if you'd like to make the contribution, feel free to open up a PR and make this API public!

from apollo-ios.

Thanks so much for the fast response, @AnthonyMDev - and glad to hear y'all are open to opening up this functionality! I agree some strong docs can help avoid foot-guns re: retain cycles, here. I'll aim to get a PR up later today; may need your help to iterate on the best copy for that comment, once the PR is up.

from apollo-ios.

Do you have any feedback for the maintainers? Please tell us by taking a one-minute survey. Your responses will help us understand Apollo iOS usage and allow us to serve you better.

from apollo-ios.