Giter Club home page Giter Club logo

Comments (6)

Cellule avatar Cellule commented on June 24, 2024 2

I'm close to get a minimal repro. Manage to at least setup http link in code sandbox at least, but it's not reproing in my setup yet
I'll try again a little later, not 100% sure what else I have on my real setup that might affect this
See current setup here
Navigating quickly between Home and Home2 causes to cancel the request, but no repro yet

from apollo-client.

jerelmiller avatar jerelmiller commented on June 24, 2024 1

Glad you found the source of the issue! Appreciate you letting us know! Have a great rest of your day 🙂

from apollo-client.

jerelmiller avatar jerelmiller commented on June 24, 2024

Hey @Cellule 👋

Thanks for the report! By chance do you see the same thing with HttpLink, or just BatchHttpLink? FWIW we do the same thing in HttpLink here:

return () => {
// XXX support canceling this request
// https://developers.google.com/web/updates/2017/09/abortable-fetch
if (controller) controller.abort();

If you're not seeing this issue in HttpLink, I think that gives us a place to start.

from apollo-client.

Cellule avatar Cellule commented on June 24, 2024

I just tested and indeed same behavior with HttpLink.

from apollo-client.

Cellule avatar Cellule commented on June 24, 2024

Alright, we finally managed to find the problem.
Turns out it has nothing to do with HttpLink.
We had some custom fetch response handling that was now getting a rejection from the fetch abort

I have updated the repro above showing the issue.

In essence we had code looking like this

const httpLink = new HttpLink({
  uri: `/graphql`,
  fetch: (...args) => {
    const res = fetch(...args);
    res.then(
      (value) => {
        // inspect response headers to update application state
      },
      // This was missing, so the rejection from fetch was unhandled in this .then()
      // Causing to print the error
      // (err) => {/* Ignore fetch errors */}
    );
    return res;
  },
});

from apollo-client.

github-actions avatar github-actions commented on June 24, 2024

Do you have any feedback for the maintainers? Please tell us by taking a one-minute survey. Your responses will help us understand Apollo Client usage and allow us to serve you better.

from apollo-client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.