Comments (4)
Hey @berzhavycha 👋
This is an interesting one and after digging into it a bit, I'd classify this as "working as expected". Let me explain why:
I see you're using useFetchTasks
in both TaskList
and the useAddTask
, which means you're actually running useSuspenseQuery
twice for the same query in the same component. This actually is working, just not in the way you're expecting. If I destructure data
from useFetchTasks
inside useAddTask
and console.log
that, I see that data
gets updated to the value you're expecting after refetch
is run.
Without going into too much technical detail, I'll just say that you're running into issues due to the way we've setup the hook for Suspense promise caching and support for React transitions. Instead, I see this is a misuse of the useSuspenseQuery
hook, so please try one of the suggestions below to get this working.
To be honest, it is very unlikely I will put much effort to "fix" this to work as you're expecting with this particular pattern because the adjustments needed in Apollo Client have a high probability of breaking support for React transitions. This is much easier to fix on your end with some adjustments to how you're consuming the hook.
Without further ado, try one of the following two things to get this working:
- Remove
useFetchTasks
fromuseAddTask
and move therefetch
call insideTaskList
.
I'm able to get the desired behavior you're after with these changes:
TaskList.tsx
- const { data } = useFetchTasks();
+ const { data, refetch } = useFetchTasks();
TaskList.tsx
- <button onClick={() => onAddTask(title)}>Add Task</button>
+ <button onClick={() => onAddTask(title).then(() => refetch())}>Add Task</button>
useAddTask.ts
export const useAddTask = (): { onAddTask: (title: string) => Promise<void> } => {
const [addTaskMutation] = useMutation<AddTaskData, AddTaskVariables>(ADD_TASK);
- const { refetch } = useFetchTasks();
- const onAddTask = async (title: string): void => {
+ const onAddTask = async (title: string): Promise<void> => {
await addTaskMutation({ variables: { input: { title } } });
- refetch();
};
return { onAddTask };
};
- Switch to
useBackgroundQuery
and pull inuseQueryRefHandlers
insideuseAddTasks
to get access to arefetch
function. This would requireuseAddTasks
taking inqueryRef
as an argument.
Option 1 is probably the simplest, but if you prefer the refetch
function inside the mutation hook, option 2 can get you there without the quirks.
Hope this helps!
from apollo-client.
Hey @berzhavycha 👋
I see you reacted to my comment above, so I'm assuming the above works for you and I will go ahead and close this issue. Feel free to reopen if I've made a mistake in my assumption!
from apollo-client.
Do you have any feedback for the maintainers? Please tell us by taking a one-minute survey. Your responses will help us understand Apollo Client usage and allow us to serve you better.
from apollo-client.
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
For general questions, we recommend using StackOverflow or our discord server.
from apollo-client.
Related Issues (20)
- React 19 has updated this SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED HOT 2
- [Data masking] Mask named fragments from data returned from `watchFragment` and `useFragment` HOT 2
- [Data masking] Mask named fragment data returned from mutations HOT 2
- [Data masking] Mask named fragments for data returned from subscriptions HOT 2
- [Data masking] Mask named fragments from data returned in `cache.readQuery` HOT 2
- [Data masking] Mask named fragments for data returned in `cache.readFragment` HOT 2
- [Data masking] Ensure data masking can lookup fragments from the fragment registry HOT 2
- Why does cache read and write operation takes a lot of time when we define client-side variable to a fragment? HOT 3
- [Data masking] Ensure data masking properly handles `null` as top-level, array item, or field with child selection set HOT 2
- [Data masking] Ensure data masking works with `@defer` payloads
- [Data masking] Provide solution for TypeScript type compatibility for APIs that use both the masked result and full result
- [Data masking] Warning for field in migrate mode is overagressive
- Websockets can't connect through reverse proxy HOT 2
- useQuery polling query does not stop issuing network requests when the skip argument switches from false to true HOT 3
- `useFragment` does not re-render as expected in v3.11.5 HOT 4
- UseFragment producing a warning during store misses (TypeError: Cannot read properties of undefined) HOT 6
- Cannot read properties of undefined (reading 'data') HOT 13
- Still no alternative to onCompleted change in 3.8 HOT 5
- useSuspenseQuery with skipToken still requires an apolloClient HOT 7
- skip: true and skipToken behave differently with useSuspenseQuery HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from apollo-client.