Tty parameter in container.attach? about dockerode HOT 5 CLOSED

https://github.com/dotcloud/docker/blob/master/api/server/server.go#L791

"/containers/{name:.*}/attach": postContainersAttach,

It works in attach (like in create) also, although it isn't in the Remote API documentation :)

from dockerode.

I believe postContainersAttach uses previously defined "Tty" value rather than get it from request parameters, because it uses

c.GetSubEnv("Config").GetBool("Tty")

instead of

r.Form.Get("stdin")

like other parameters. I believe "c" variable is something like container settings given from "inspect", and "r" is request.

from dockerode.

I jumped the gun. Yup you are right.
I'm 99% sure this worked on 1.6, because those examples were copy-pasted from other code we had in dockerode.
From API's 1.6 to 1.11 there were major refactoring I believe, don't have time to check the git commit log but it is possible this was corrected. probably?

Nevertheless let's change the documentation/examples, to use the tty option in create and not on attach and to comply with the Remote API documentation and the reality :)

Wanna do a PR to fix this, since it was your find? :)

from dockerode.

Yeah! Will do. I will close this issue when open new PR.

from dockerode.

PR done, so close this issue

from dockerode.