use http://docs.vagrantup.com/v2/provisioning/docker.html instead of bash script in vagrant file about dockerode HOT 5 CLOSED

Requires vagrant 1.4x but it makes things easier... I am noticing that the tests expect at least one image to be downloaded prior to having the tests run... This is a simple fix with the bash setup but is cleaner under the new vagrant docker provisioner.

from dockerode.

This Vagrantfile is a stripped down version from https://github.com/dotcloud/docker/blob/master/Vagrantfile it was a quick hack at the time.

Will look into that.

Regarding the download, Docker will pull the image during the tests. The issue is that you need to specify an existing container id in order to test container manipulation. (this should be fixed, this container should be created dynamically in the tests)

Issue: https://github.com/apocas/dockerode/blob/master/test/container.js#L4

from dockerode.

right! I noticed this after the fact... Are you open to creating the image dynamically? I can submit a quick fix.

from dockerode.

Sure, go ahead!

from dockerode.

Vagrantfile was so simplified few releases ago, that now it's practically just a simple bash script to install a few packages.

For now let's leave it this way, since it does rely much on Vagrant I hope it will endurance breaking change and what not in Vagrant future versions.
( This is what I hope at least, since I don't want to waste time on this :) )

from dockerode.