Comments (3)
apocas
commented on July 27, 2024
Just add the container to the callback in https://github.com/apocas/dockerode/blob/master/lib/docker.js#L241
Feel free to do a PR, i think it's interesting for everyone to fetch the container in the end when they don't specify a temporary run.
There are also a few nasty loopholes in #run. Like the callback being called multiples times if attach and/or start fails. Feel free to refactor it a bit like you did in docker-modem :-D
PS: Happy new year!
from dockerode.
lightsofapollo
commented on July 27, 2024
@apocas Will do- I noticed his as well ( I hacked a quick internal implementation )
from dockerode.
lightsofapollo
commented on July 27, 2024
Fixed in #20
from dockerode.
Related Issues (20)
- Pushing an image to private registry with auth not working HOT 1
- Error while installing with pnpm
- ContainerStartOptions does not contain abortSignal property HOT 1
- Missing Changelog HOT 5
- Specifying socketPath but Dockerode is using HTTP. (bun.js) HOT 13
- Image name when we use buildImage doesn't work HOT 1
- Changelog HOT 4
- Undocumented breaking change: container.logs now produces a string HOT 8
- Error building image
- Error to get logs on some containers HOT 1
- Passing filter options to pruneImages HOT 1
- Module parse failed: Unexpected character '�' (1:0) HOT 1
- Restore exec stream
- Source directory and Dockerfile in different locations HOT 2
- Clone a container HOT 1
- unable to handle ssh network errors HOT 2
- Sending User Input via Attach or Other
- Missing type `CreatedAt` from `listVolumes()`
- Missing option type `force: boolean` from `volume.remove()` HOT 1
- TypeError: this.modem.Promise is not a constructor HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dockerode.