Giter Club home page Giter Club logo

Comments (2)

apiad avatar apiad commented on August 19, 2024

Hey, I'm really happy to hear that someone finds this project useful!

Of course, I would love to merge your requests, if it makes your use case easier. I like the approach of making everything configurable but with sensible defaults, so if tight_layout is something that most of the time would work better as True, then I would prefer to have that as an optional parameter with default value True. If I understand well this is what your proposal is actually about.

In any case, yes, feel free to make the changes you consider relevant and I'll be more than happy to merge your pull requests. Another thing, there are unmerged changes in develop so maybe it is best if you branch out from there instead of master because in the long run those changes will be merged in. If this creates too much trouble then don't worry, it's just so that later those changes are easier to merge.

Finally, it's not absolutely necessary, but if you feel that adding an example to the demo slide is useful, then be my guest. We unit-test the demo (at least that it runs without errors) so this at least ensures that the parameters used are in sync with the API.

from auditorium.

apiad avatar apiad commented on August 19, 2024

from auditorium.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.