Giter Club home page Giter Club logo

Comments (3)

sroze avatar sroze commented on August 17, 2024

Just my opinion about the "year support" and the format. I think that we have to use the ISO 8601 format of datetime and that we shouldn't at all support other formats (such as year only) because the decision to use 00:00:00 or 23:59:59 as time or even 01-01 or 12-31 as day is something that depends on needs.

from core.

theofidry avatar theofidry commented on August 17, 2024

@sroze What about letting DateTime handling that for you? The user would be warned that the only requirement for his date to be valid is to be accepted by DateTime aside from edge cases like for the year support. If we follow the ISO 8601 format we have to specify the hour, minutes and seconds which in many cases is unnecessary.

from core.

dunglas avatar dunglas commented on August 17, 2024

I'm for blindly pass the value to the DateTime constructor but advertise only that ISO 8601 dates are supported in the doc.
ISO 8601 should be the preferred way because it's standard (and used in JSON-LD) but this approach give more flexibility for advanced users knowing of the bundle and PHP works internally (we must keep in mind that final users are people consuming the API from various langages such as JavaScript and Ruby).

from core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.