Giter Club home page Giter Club logo

Comments (6)

potiuk avatar potiuk commented on August 23, 2024

I suggest to use .dockerignore and follow the "exclude all, add what is needed pattern". This is much better approach.

# Ignore everything
**

# Allow only these directories
!airflow
!common

https://github.com/apache/airflow/blob/147bcecc4902793e0b913dfdad1bd799621971c7/.dockerignore#L26

from www-site.

potiuk avatar potiuk commented on August 23, 2024

Main reason is because you cannot add files from outside the context to docker context so you have to do weird things to add top files or files from not under directory where Dockerfile is placed. Then you cannot really do the usual docker build . -f Dockerfile but you either have to provide different context anyway or somehow copy over the files you need to under docker folder.

from www-site.

sebbASF avatar sebbASF commented on August 23, 2024

Good point, but AFAICT in this case there are no files needed...

from www-site.

potiuk avatar potiuk commented on August 23, 2024

Until they are :)

from www-site.

potiuk avatar potiuk commented on August 23, 2024

You can exclude everything then

.dockerignore

# Ignore everything
**

from www-site.

dave2wave avatar dave2wave commented on August 23, 2024

You should be joining the conversation on PR #60 where we have yet to decide the ultimate location

from www-site.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.