Comments (9)
We should make the old behavior optional to enable as well, there's a significant number of backends (origins) that do not support RFC7239 yet but need the old semantics.
from trafficserver.
I thought the old behavior was already optional.
{RECT_CONFIG, "proxy.config.http.insert_squid_x_forwarded_for", RECD_INT, "1", RECU_DYNAMIC, RR_NULL, RECC_NULL, NULL, RECA_NULL}
from trafficserver.
Right, but your comments say "replaces". I think we should keep both, indefinitely.
from trafficserver.
Fair enough, description fixed.
from trafficserver.
I have some one here at Y! who will be working on this.
from trafficserver.
To records.config I'm thinking to add:
CONFIG proxy.config.http.insert_forwarded STRING {value}
{value} would either be 'none' (the default) or list of options, separated by '|' (pipe).
options:
for
by={by-value}
proto
host
connection
These would enable variables in the header. "connection" is a non-standard variable, which will contain the most verbose protocol specifier from the "Via:" header.
{by-value} can be "ip", "unknown", "servername" or "uuid". The UUID would have a prepended _ (underscore) to make it a legitimate obfuscated identifier per RFC 7239.
from trafficserver.
I'd like to add to "connection" the ability to specific some levels of detail, e.g.
connection=full
connection=std
connection=compact
with the same meaning as for the VIA header.
from trafficserver.
It's already in there and ready to be savaged.
from trafficserver.
I believe this has been fully completed. Please reopen if need be.
from trafficserver.
Related Issues (20)
- traffic_ctl config match is confused with metrics HOT 2
- CI txn_box ramp autest failure HOT 2
- Some unit tests are failing under asan on master
- Documentation's latest no longer has version drop down HOT 1
- records.yaml validation on loading HOT 1
- 9.2.3 traffic_server -Cclear with over 99 devices in storage.config crashes with segmentation fault HOT 2
- "Release Process" section of sphinx documentation needs updates. HOT 1
- heap use after free in QUICStreamAdapter::stream via HQTransaction::get_transaction_id HOT 2
- libswoc is using undefined macros BYTE_ORDER and LITTLE_ENDIAN
- Decrypting private SSL keys is broken due to missing pass phrase callback in SSLPrivateKeyHandler HOT 1
- Support for Early Data is not checked properly HOT 4
- Did nexthop_test_stubs.cc missed the cmake train? HOT 1
- AddressSanitizer: heap-use-after-free HQSession::main_event_handler HOT 1
- Trafficserver fails to load plugin on Debian HOT 1
- Crash with HTTP2_SESSION_EVENT_DATA
- Crash on ActivityCop of Http2ConnectionState
- AddressSanitizer: odr-violation: global 'DbgCtl::_config_mode' HOT 4
- traffic_ctl host status command small memory leak
- Remap plugin loading unit tests failing. HOT 2
- The Apache Traffic Server is not listening on port 80 after starting the service ( service is active! ) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from trafficserver.