Giter Club home page Giter Club logo

Comments (9)

zwoop avatar zwoop commented on May 23, 2024

We should make the old behavior optional to enable as well, there's a significant number of backends (origins) that do not support RFC7239 yet but need the old semantics.

from trafficserver.

PSUdaemon avatar PSUdaemon commented on May 23, 2024

I thought the old behavior was already optional.

{RECT_CONFIG, "proxy.config.http.insert_squid_x_forwarded_for", RECD_INT, "1", RECU_DYNAMIC, RR_NULL, RECC_NULL, NULL, RECA_NULL}

from trafficserver.

zwoop avatar zwoop commented on May 23, 2024

Right, but your comments say "replaces". I think we should keep both, indefinitely.

from trafficserver.

PSUdaemon avatar PSUdaemon commented on May 23, 2024

Fair enough, description fixed.

from trafficserver.

SolidWallOfCode avatar SolidWallOfCode commented on May 23, 2024

I have some one here at Y! who will be working on this.

from trafficserver.

ywkaras avatar ywkaras commented on May 23, 2024

To records.config I'm thinking to add:

CONFIG proxy.config.http.insert_forwarded STRING {value}

{value} would either be 'none' (the default) or list of options, separated by '|' (pipe).

options:

for
by={by-value}
proto
host
connection

These would enable variables in the header. "connection" is a non-standard variable, which will contain the most verbose protocol specifier from the "Via:" header.

{by-value} can be "ip", "unknown", "servername" or "uuid". The UUID would have a prepended _ (underscore) to make it a legitimate obfuscated identifier per RFC 7239.

from trafficserver.

SolidWallOfCode avatar SolidWallOfCode commented on May 23, 2024

I'd like to add to "connection" the ability to specific some levels of detail, e.g.
connection=full
connection=std
connection=compact
with the same meaning as for the VIA header.

from trafficserver.

ywkaras avatar ywkaras commented on May 23, 2024

It's already in there and ready to be savaged.

from trafficserver.

bryancall avatar bryancall commented on May 23, 2024

I believe this has been fully completed. Please reopen if need be.

from trafficserver.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.