Giter Club home page Giter Club logo

Comments (10)

aooohan avatar aooohan commented on June 14, 2024 1

I've meanwhile switched back to version 1.0.0 which works as intended.

Sure. The difference between 1.0.0 and 1.0.1 is that in order to solve #20, the logic was modified to use common-compression instead of JDK's zip implementation.

Hi,@gregorkistler.
I've tried to fix the problem, can you test it with this fixed version?
branch: https://github.com/aooohan/tomcat-jakartaee-migration/tree/test_deflated
OR
jar:
jakartaee-migration-1.0.2-SNAPSHOT-bin.tar.gz

1.tar -zxvf jakartaee-migration-1.0.2-SNAPSHOT-bin.tar.gz
2.cd jakartaee-migration-1.0.2-SNAPSHOT/lib
3.java -jar jakartaee-migration-1.0.2-SNAPSHOT.jar jna-platform-4.5.1.jar jna-platform-4.5.1.jar.jakarta

Note: This is not a release version, it has nothing to do with tc offical, it is only for testing.

Thanks

from tomcat-jakartaee-migration.

gregorkistler avatar gregorkistler commented on June 14, 2024 1

Hi,@gregorkistler. I've tried to fix the problem, can you test it with this fixed version? branch: https://github.com/aooohan/tomcat-jakartaee-migration/tree/test_deflated OR jar: jakartaee-migration-1.0.2-SNAPSHOT-bin.tar.gz

1.tar -zxvf jakartaee-migration-1.0.2-SNAPSHOT-bin.tar.gz 2.cd jakartaee-migration-1.0.2-SNAPSHOT/lib 3.java -jar jakartaee-migration-1.0.2-SNAPSHOT.jar jna-platform-4.5.1.jar jna-platform-4.5.1.jar.jakarta

Note: This is not a release version, it has nothing to do with tc offical, it is only for testing.

Thanks

LGTM

No exception any longer on any of the used jars. Thanks!

from tomcat-jakartaee-migration.

nissan4x4 avatar nissan4x4 commented on June 14, 2024 1

from tomcat-jakartaee-migration.

aooohan avatar aooohan commented on June 14, 2024

You can do it like this: java -jar jakartaee-migration-1.0.1-shaded.jar -zipInMemory jna-platform-4.5.1.jar jna-platform-4.5.1.jar.jakarta

It's a little inefficient, but it'll work.

from tomcat-jakartaee-migration.

gregorkistler avatar gregorkistler commented on June 14, 2024

It's a little inefficient, but it'll work.

Thank you. Yes it works but as you've mentioned it's quite inefficient - takes ~150s instead of ~500ms for this specific jar and my project contains roughly 20 jar files 😅
I've meanwhile switched back to version 1.0.0 which works as intended.

from tomcat-jakartaee-migration.

aooohan avatar aooohan commented on June 14, 2024

Hi,@gregorkistler. I've tried to fix the problem, can you test it with this fixed version? branch: https://github.com/aooohan/tomcat-jakartaee-migration/tree/test_deflated OR jar: jakartaee-migration-1.0.2-SNAPSHOT-bin.tar.gz
1.tar -zxvf jakartaee-migration-1.0.2-SNAPSHOT-bin.tar.gz 2.cd jakartaee-migration-1.0.2-SNAPSHOT/lib 3.java -jar jakartaee-migration-1.0.2-SNAPSHOT.jar jna-platform-4.5.1.jar jna-platform-4.5.1.jar.jakarta
Note: This is not a release version, it has nothing to do with tc offical, it is only for testing.
Thanks

LGTM

No exception any longer on any of the used jars. Thanks!

Thanks for the test. ;)

from tomcat-jakartaee-migration.

nissan4x4 avatar nissan4x4 commented on June 14, 2024

Hi, @aooohan. I am experiencing the same issue as @gregorkistler with the CRC.

18-Aug-2022 14:55:06.339 WARNING [Catalina-utility-1] org.apache.catalina.startup.HostConfig.migrateLegacyApp Migration failure
	java.util.zip.ZipException: Bad CRC checksum for entry META-INF/MANIFEST.MF: 277a0274 instead of 5cfc51fe
		at org.apache.tomcat.jakartaee.commons.compress.archivers.zip.ZipArchiveOutputStream.handleSizesAndCrc(ZipArchiveOutputStream.java:718)

OS is Windows 2019 server
JAVA 8 (jre-8u341-windows-i586)
Tomcat 10.0.23

I'm having TC do the migration by placing the *.war into the webapps-javaee folder.

from tomcat-jakartaee-migration.

aooohan avatar aooohan commented on June 14, 2024

Hi, @nissan4x4
jakartaee-migration-1.0.2-SNAPSHOT-bin.tar.gz

You can use this temporary tool to test whether the migration of your war package works.

  • tar -zxvf jakartaee-migration-1.0.2-SNAPSHOT-bin.tar.gz
  • cd jakartaee-migration-1.0.2-SNAPSHOT/lib
  • java -jar jakartaee-migration-1.0.2-SNAPSHOT.jar your-war.war target-your-war.war OR java -jar jakartaee-migration-1.0.2-SNAPSHOT.jar your-war-dir target-dir

Note: This is not a release version, it has nothing to do with tc offical, it is only for testing.

from tomcat-jakartaee-migration.

nissan4x4 avatar nissan4x4 commented on June 14, 2024

from tomcat-jakartaee-migration.

aooohan avatar aooohan commented on June 14, 2024

but my OS is windows not Unix.

Sorry, I was careless.
jakartaee-migration-1.0.2-SNAPSHOT-bin.zip

The steps are the same, first you need to unzip the package, then go to the lib folder and execute the jakartaee-migration-1.0.2-SNAPSHOT.jar file(the command is the same).

JAVA_HOME/bin/java.exe -jar jakartaee-migration-1.0.2-SNAPSHOT.jar your-war.war target-your-war.war

from tomcat-jakartaee-migration.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.