Giter Club home page Giter Club logo

Comments (5)

dosubot avatar dosubot commented on August 26, 2024 2

Hey @Dinesh2019! πŸ‘‹ I'm here to help you with any bugs, questions, or contributions you have for the project. Let's work together to resolve any issues you're experiencing.

The data misalignment issue when applying filters in line-list reports could be related to recent changes in the dependencies or styles used by Superset. Specifically, the removal of the Filter Box code and the filters set feature might be affecting how filtered data is rendered [1][2][3].

Additionally, recent changes in the Styles.js file could impact the layout and alignment of data. These changes include adjustments to the positioning, borders, padding, font sizes, and colors of table elements [4].

To address this issue, you can try the following steps:

  1. Revert Positioning Changes:

    • Ensure the position property for table elements is set correctly. For example:
      position: 'relative'; // or 'inherit' based on the previous state
  2. Adjust Borders and Padding:

    • Modify or remove the border and padding properties if they are causing misalignment. For example:
      border-bottom: none; // or adjust the border value
      padding: 0; // or set to a different value
  3. Font and Color Adjustments:

    • Revert font sizes, weights, and colors to their previous values if the new ones are causing issues. For example:
      font-size: '14px'; // or the previous size
      color: '#000'; // or the previous color

Here is an example of how you might adjust the Styles.js file:

export const Styles = styled.div`
  ${({ theme, isDashboardEditMode }) => css`
    table.pvtTable {
      position: 'relative'; // Revert to previous value
      width: calc(100% - ${theme.gridUnit}px);
      font-size: '14px'; // Revert to previous size
      text-align: left;
      margin: ${theme.gridUnit}px;
      border-collapse: separate;
      font-family: ${theme.typography.families.sansSerif};
      line-height: 1.4;
    }

    table thead {
      position: 'relative'; // Revert to previous value
      top: 0;
    }

    table tbody tr {
      font-feature-settings: 'tnum' 1;
    }

    table.pvtTable thead tr th,
    table.pvtTable tbody tr th {
      background-color: ${theme.colors.grayscale.light5};
      border-top: none; // Adjust border
      border-left: none; // Adjust border
      font-size: '14px'; // Revert to previous size
      padding: 0; // Adjust padding
      font-weight: ${theme.typography.weights.normal};
    }

    table.pvtTable tbody tr.pvtRowTotals {
      position: 'relative'; // Revert to previous value
      bottom: 0;
    }

    // Other styles remain unchanged
  `}
`;

Adjust the values as needed based on the specific issues you are encountering.

To continue talking to Dosu, mention @dosu.

from superset.

rusackas avatar rusackas commented on August 26, 2024 1

Hello, i can work on this. Please assign it to me.

Done! Thanks for volunteering. We're not hung up on the assignments around here... please feel free to open a PR for any open issue you'd like :D

from superset.

gagan-bhullar-tech avatar gagan-bhullar-tech commented on August 26, 2024

Hello, i can work on this. Please assign it to me.

from superset.

gagan-bhullar-tech avatar gagan-bhullar-tech commented on August 26, 2024

@Dinesh2019 Unable to reproduce the issue. Can you please provide specific steps with the test datasets.

from superset.

Dinesh2019 avatar Dinesh2019 commented on August 26, 2024

@gagan-bhullar-tech i think we cant provide me the datasets.

from superset.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.