Giter Club home page Giter Club logo

Comments (12)

mdedetrich avatar mdedetrich commented on August 17, 2024

Ill look into this

from pekko-http.

mdedetrich avatar mdedetrich commented on August 17, 2024

@pjfanning So I think the core issue is this https://github.com/ThoughtWorksInc/sbt-api-mappings/blob/5b1e4f11647421d287d3a26ed7fb077474ea7a3e/src/main/scala/com/thoughtworks/sbtApiMappings/BootstrapApiMappings.scala#L37-L43 although I am still getting the issue when running with JDK 11, investigating further

from pekko-http.

mdedetrich avatar mdedetrich commented on August 17, 2024

Re-opening since its still broken

from pekko-http.

pjfanning avatar pjfanning commented on August 17, 2024

@mdedetrich is this safe to close? - we have the link-validator job running in CI

from pekko-http.

mdedetrich avatar mdedetrich commented on August 17, 2024

Yes

from pekko-http.

jrudolph avatar jrudolph commented on August 17, 2024

No, the link validator is still broken.

from pekko-http.

mdedetrich avatar mdedetrich commented on August 17, 2024

@jrudolph Huh? https://github.com/apache/incubator-pekko-http/actions/runs/5643524801

from pekko-http.

jrudolph avatar jrudolph commented on August 17, 2024

Last time it ran, it failed, and then removed its settings accidentally...

https://github.com/apache/incubator-pekko-http/actions/runs/5643524801/job/15285543470#step:8:9

can't read [scripts/link-validator.conf]

It seems to fail silently.

from pekko-http.

mdedetrich avatar mdedetrich commented on August 17, 2024

Oh I see, let me rename issue so it's clearer then

from pekko-http.

jrudolph avatar jrudolph commented on August 17, 2024

This issue is probably still existing, and the other is another issue which masks this.

from pekko-http.

mdedetrich avatar mdedetrich commented on August 17, 2024

This issue is probably still existing, and the other is another issue which masks this.

I remember fixing/verifying the broken links, so unless some change was introduced which broke the links it should be fine.

from pekko-http.

jrudolph avatar jrudolph commented on August 17, 2024

👍

from pekko-http.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.