regression in wsk cli tests correlated to client-go commit 67f06bc about openwhisk-client-go HOT 7 CLOSED

@dgrove-oss @rabbah From what I can tell, the failing test basically invokes an action, then polls for activations using wsk activation poll and verifies that it gets exactly one activation, but for some reason it gets 2. Looking at the changes I introduced, its hard to see how the two methods I modified could have anything to do with that, since all they do is return a header and a string representation of the activation when invoking wsk activation list. The API itself has not been changed, so its hard for me to explain what is going on here. But I also noticed that the second test in the same class fails as well, and for that there is an issue #4328. Could they be related?

from openwhisk-client-go.

Can we prove this out with a unit test in client-go?

from openwhisk-client-go.

@dubee Don't think so. The test needs to be run against a working OpenWhisk environment. That's probably why it's in the main repo instead of the cli one. Anyway, I made sure my cli repo was in sync with upstream master, updated build.gradle to point to my commit in client-go, built the CLI, then updated my controller and invoker to the latest image and run the failing test manually in CLI (create action, poll for activations, invoke action), and it works just fine! I've also gone over the code and I'm pretty confident that the code I changed never is called from the failing test.

from openwhisk-client-go.

I have reproduced the failure locally. The answer may be the following: this is the result of activation list as it appears now for me built with the hashes from apache/openwhisk-cli#423

EDIT: this may be a red herring... there is some extra white space at the end of the line that is wrapping on stdout if the font is too big.

from openwhisk-client-go.

@dubee Don't think so. The test needs to be run against a working OpenWhisk environment. That's probably why it's in the main repo instead of the cli one. Anyway, I made sure my cli repo was in sync with upstream master, updated build.gradle to point to my commit in client-go, built the CLI, then updated my controller and invoker to the latest image and run the failing test manually in CLI (create action, poll for activations, invoke action), and it works just fine! I've also gone over the code and I'm pretty confident that the code I changed never is called from the failing test.

We can provide mock backend activation responses to the client-go test, however.

from openwhisk-client-go.

PR opened to address the format change. I think mocking would not have been caught it.

from openwhisk-client-go.

We're tracked down and fixed this

from openwhisk-client-go.