Giter Club home page Giter Club logo

Comments (3)

bongohrtech avatar bongohrtech commented on May 20, 2024

I believe NUnit should have an overload for numeric types but when comparing type long this seems to take a very long time to resolve. Using an overload a == b seems to result in much faster performance. The same is true for byte comparison.

This as been added to the Assert.cs file which overloads AreEqual for long and byte

from lucenenet.

bongohrtech avatar bongohrtech commented on May 20, 2024

Tests in T-U seem to have been resolved where there is the most delay.
Adding the following line will force the tests to use the overloaded methods.

using Assert = Lucene.Net.TestFramework.Assert;

assertEquals in LuceneTestCase has also been modified to use the same equivalence checks

from lucenenet.

NightOwl888 avatar NightOwl888 commented on May 20, 2024

@bongohrtech - Good find. There are several tests that are passing value types through Assert.AreEqual(object, object) in a tight loop, causing lots of box/unbox operations. And of course, this problem isn't limited to the Lucene.Net.Util namespace.

I have confirmed that changing this gets both T-U and U-Z projects to run in under 3.5 minutes, which were more like 11 minutes before.

We should aim to apply this fix on all of the projects starting with the longest running ones:

  • Lucene.Net.Tests._E-I
  • Lucene.Net.Tests.Analysis.Common
  • Lucene.Net.Tests.Codecs
  • Lucene.Net.Tests._A-D
  • Lucene.Net.Tests._J-S

We can probably also consolidate some of the 5 Lucene.Net test projects that were broken up, which should help to speed up the overall time in Azure DevOps.

from lucenenet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.