Comments (5)
PragmaTwice
commented on June 9, 2024
Hi @photoszzt , thank you for your suggestion!
It is important to prevent data loss, but I wonder the performance impact of this option.
And should we enable sync mode by default, or we make it a configuration option (kvrocks.conf) for users?
from kvrocks.
git-hulk
commented on June 9, 2024
Yes, this option might heavily affect the performance, so guess it will be better to make a configuration option for users.
from kvrocks.
photoszzt
commented on June 9, 2024
@PragmaTwice There's an option in the conf file: rocksdb.write_options.sync. It's set to no right now. I assume it will set WriteOptions.sync=true when I change this config to yes. I'm going to see how much slower if this is set to yes.
from kvrocks.
mapleFU
commented on June 9, 2024
I don't think we should change our default behavior here. But you can edit yourself's config
I assume it will set WriteOptions.sync=true when I change this config to yes.
Yes.
from kvrocks.
git-hulk
commented on June 9, 2024
@photoszzt I'm sorry for forgetting this configuration has been supported, you can achieve this by adding rocksdb.write_options.sync yes to your configuration file. cc @PragmaTwice @mapleFU
Close this issue since it has been resolved, feel free to reopen it if you have any questions.
from kvrocks.
Related Issues (20)
- Optimization of Lua Global Locks HOT 2
- can kvrocks have a winows sln to comiple in wondows server？
- Add option to disable incremental sync in kvrocks2redis
- Add support of the command READONLY & READWRITE HOT 4
- kvrocks2redis migrate kvrocks to kvrocks-cluster
- Add support of the command ASKING HOT 5
- Introducing Get Metadata with rocksdb::Snapshot HOT 1
- JSON.SET cant add a new field HOT 3
- kvrocks2redis can't sync flush commands HOT 5
- The slave of the kvrocks cluster failed to synchronize data from the master HOT 3
- Add support of the XAUTOCLAIM command HOT 4
- Add support of the command CLUSTER RESET
- CLUSTERX SETNODES - ERR Slot is out of range HOT 2
- KVRocks cluster does not support failover. HOT 2
- Reduce the number of write buffers for infrequently used column families HOT 9
- Memory issue of kvrocks2redis detected by ASan/TSan HOT 5
- Don't allow to import the cluster slot which belongs to itself
- Add support FT (Searching and querying Redis data) HOT 1
- Scan command support non-prefixed string matching HOT 10
- Check iterator status after quit loop HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kvrocks.