Giter Club home page Giter Club logo

Comments (6)

swartik avatar swartik commented on May 27, 2024 1

Good point. I will come up with a solution that can't insert an empty argument.

from jena.

kinow avatar kinow commented on May 27, 2024

Adding quotes should be ok and fix the issue here. Would you like to send a small pull request for that? Thanks!

from jena.

afs avatar afs commented on May 27, 2024

There is a corner case : suppose "$FUSEKI_HOME/log4j2.properties" does not exist then LOGGING isn't set and $LOGGING expands on the command line to no argument. But if it is quoted, it puts in an empty string argument. And because it has no leading "-" it cuts off the command flags.

Is there a way to put it on the command as a single argument if not the empty string and nothing if empty.

An alternative is to to set LOGGING to some no-op like -Dnosuch=novalue.

from jena.

swartik avatar swartik commented on May 27, 2024

I've pushed another commit that quotes LOGGING if it's not empty.

The code assumes LOGGING will expand to a single argument. That is,

$ export LOGGING='-Dlog4j.configurationFile=myconfig.properties -DmyLogVar=value'
$ fuseki-server

won't work. I assume this isn't a problem, because the argument could be provided in JVM_ARGS. Let me know if I'm mistaken.

from jena.

afs avatar afs commented on May 27, 2024

No, shouldn't be a problem.

from jena.

swartik avatar swartik commented on May 27, 2024

I think we're good to go, then. Let me know if there's anything else you need from me.

from jena.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.