Comments (7)
Could I argue that the "commands" used to make these changes, that result in "massive commits", should be checked in as a script in a commit before the actual rename, so that:
- The script can be reviewed instead of the change
- The script can be applied to check that the rename commit result matches the script execution
from incubator-pekko.
@pjfanning Since #20 is abandoned, are you going to recreate it or should I? I was also thinking of rather than renaming the modules from akka-*
to pekko-*
(i.e. akka-actor
to pekko-actor
) that instead we should just have the module name without pekko
(i.e. akka-actor
would just become actor
).
The reasoning is the same as renaming akka-docs
to just docs
, i.e. its extra/unneeded noise and its also not consistent with the other pekko repo's (i.e. alpakka doesn't have akka-
prefix for each of their sbt modules). Since we are renaming the sbt modules anyways there isn't going to be any extra noise, only thing we need to do is to make sure to add the pekko-
prefix in the generated jar which is quite easy.
Should also do this after #35 gets merged so as to not deal with a lot of merge conflicts.
from incubator-pekko.
@pjfanning Since #20 is abandoned, are you going to recreate it or should I? I was also thinking of rather than renaming the modules from
akka-*
topekko-*
(i.e.akka-actor
topekko-actor
) that instead we should just have the module name withoutpekko
(i.e.akka-actor
would just becomeactor
).The reasoning is the same as renaming
akka-docs
to justdocs
, i.e. its extra/unneeded noise and its also not consistent with the other pekko repo's (i.e. alpakka doesn't haveakka-
prefix for each of their sbt modules). Since we are renaming the sbt modules anyways there isn't going to be any extra noise, only thing we need to do is to make sure to add thepekko-
prefix in the generated jar which is quite easy.Should also do this after #35 gets merged so as to not deal with a lot of merge conflicts.
I'd prefer to keep the dir names for the modules to match the jar names. And I think the jar names should be like 'pekko-actor', etc.
from incubator-pekko.
I'd prefer to keep the dir names for the modules to match the jar names.
Right, but this is only the case for core akka, every other akka repo does not follow in this. In fact arguably from what I have seen in standard OS SBT projects, this isn't really idiomatic or standard practice either (i.e. having folders the same as jar names). There is no correlation of folder name to jar, and hence in some cases it can be misleading.
And I think the jar names should be like 'pekko-actor', etc.
This would be unchanged even with my suggestion, in fact its very easy to do this with SBT.
Would you be more open if I created a PR demonstrating this? Its actually not that hard.
from incubator-pekko.
sure, try it out
from incubator-pekko.
I guess this is what #71 is about.
from incubator-pekko.
#71 is merged
from incubator-pekko.
Related Issues (20)
- Async DNS Resolver should not use predictable IDs in requests HOT 1
- Remove/replace inactive spotify docker-client test dependency
- Improve performance of `IdGenerator.EnhancedDoubleHashGenerator`
- Find ACM equivalent of https://dspace.jaist.ac.jp/dspace/bitstream/10119/4784/1/IS-RR-2004-010.pdf HOT 2
- Add/enable scalafix in pekko HOT 1
- Avoid usage of `sun.misc.Unsafe` HOT 2
- acknowledge use of Aeron code in Pekko HOT 4
- acknowledge use of cowtowncoder code HOT 2
- acknowledge licensing issues in AbstractBoundedNodeQueue HOT 2
- acknowledge licensing issues in AbstractNodeQueue HOT 6
- examine potential copy of scala-library code HOT 2
- Allow building on jdk19 HOT 3
- acknowledge licensing issue in PrettyByteString HOT 2
- acknowledge use of riak code in ORSet HOT 3
- acknowledge hash-prospector use in FrequencySketch (public domain) HOT 1
- examine whether there is any Ben Manes' code in FrequencySketch HOT 6
- include critical TLS fix from Akka 2.6.21 (pekko-stream TLSActor) HOT 1
- acknowledge use of Play based scripts HOT 1
- Docs: child actors automatically restarted only if they were created in setup method ?? HOT 1
- Migrate multi-node-testkit to netty 4 HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from incubator-pekko.