[SUPPORT] Archive operation always release lock on the timeline when try lock failed about hudi HOT 9 OPEN

otherwise is there a chance of mistakenly releasing the lock of other operations and causing problems?

That's reasonable, we should ensure the lock been acquired in the first place.

from hudi.

archive itself holds an transaction lock, so we need to release it in any case, what is the wrong case you have ecountered?

from hudi.

@danny0405 Sorry, I don't remember the details of the problem (I will confirm with my colleagues and provide the results later), but based on the logic here, wouldn't it be better to attempt to release the lock only when acquiring it, otherwise is there a chance of mistakenly releasing the lock of other operations and causing problems?

from hudi.

@danny0405 @Ytimetravel The behavior of method TransactionManager#endTransaction itself is correct, it would check whether the current lock is hold by itself before it unlock. However, there is a bug in HoodieTimelineArchiver because archiving itself is not a transaction and does not correspond to any instant in timeline. When an exception occurs, it might mistakenly deletes locks held by others.

@Ytimetravel Would you like to fix this issue?

from hudi.

@beyond1920 Yes, I am very willing to fix this issue.

This fix has already been tested and verified~

from hudi.

What is the general reason that the trasanction start of archival is failing?

from hudi.

@danny0405 Failed to acquire lock.

from hudi.

from hudi.

Okay, it would be great if you can fire a fix for it.

from hudi.