[Discussion]Why not use nsoperation queue instead of dispatch queue in CDVCommandDelegateImpl.m? about cordova-ios HOT 7 OPEN

Attached the screenshot when deadlock happen, the SyncArraryQueue is the same as DispatchQueue mentioned above. The wrap_dispatch_sync is blocked by Disptachqueue.async as it is set as a barrier for SyncArraryQueue.

queue.async(flags: .barrier)

And the async task in SyncArraryQueue is pending as the GCD has reach the thread limitation. In normal case, the deadlock should not happen.

from cordova-ios.

The primary ask is to consider using NSOperation to have a limitation on the concurrency of the async plugin api calls instead of use dispatch queue directly and facing the potential abuse(calling it simultaneously for hundreds time) from the javascript side.

from cordova-ios.

Any maintainer could have a look at this issue？Or more input from myside is needed?@janpio

from cordova-ios.

from cordova-ios.

It sounds reasonable and the change seems minor, but I know too little of the subject to properly assess the change.

from cordova-ios.

It would be great if someone could post a plugin that demonstrates this issue.

From some quick research I think this would be a nice enhancement for a major release, someday in the future. It should be pretty straightforward: https://stackoverflow.com/questions/39952743/how-to-use-nsoperation-nsoperationqueue-in-objective-c

I found another really nice resource at: https://cocoacasts.com/choosing-between-nsoperation-and-grand-central-dispatch/

A pull request would definitely be welcome.

from cordova-ios.

@brodybits The PR is already at #454

from cordova-ios.