Giter Club home page Giter Club logo

Comments (6)

ppalaga avatar ppalaga commented on July 29, 2024

I clearly see the benefit of testing separately and having a separate project for each component that can serve as a basic quickstart.

OTOH, each separate integration test module will prolong the build by ~2 minutes. Do we really want that? My personal limit for CI is ~40mins. Now we are at ~28mins, IIRC. So we can basically do this, but maybe for the future, we should think of some sort of policy that would keep the CI run times reasonable. Testing several extensions in one IT module is actually one possible solution, so once again the question, is it really worth splitting now?

from camel-quarkus.

oscerd avatar oscerd commented on July 29, 2024

I think a reasonable time for CI can be more than 40 minutes.

from camel-quarkus.

ppalaga avatar ppalaga commented on July 29, 2024

I think a reasonable time for CI can be more than 40 minutes.

I wonder what is your upper bound for a CI job that verifies pull requests?

from camel-quarkus.

oscerd avatar oscerd commented on July 29, 2024

it depends on the dimension of a project: in camel we cannot do a full build because it's too much stuff for a single PR. I think up to 90 minutes is reasonable.

from camel-quarkus.

lburgazzoli avatar lburgazzoli commented on July 29, 2024

I clearly see the benefit of testing separately and having a separate project for each component that can serve as a basic quickstart.

OTOH, each separate integration test module will prolong the build by ~2 minutes. Do we really want that? My personal limit for CI is ~40mins. Now we are at ~28mins, IIRC. So we can basically do this, but maybe for the future, we should think of some sort of policy that would keep the CI run times reasonable. Testing several extensions in one IT module is actually one possible solution, so once again the question, is it really worth splitting now?

There's no rush to move them out of core now but we should provide more tests for every extensions to aver better coverage for native compiled code (as today the tests we have for nett4-http and infinispan are the bare minimum).

BTW, nothing is written in stones and we can always rethink our decisions and group modules when it make sense but IMHO, testing component extension inside the core one is just bad.

from camel-quarkus.

ppalaga avatar ppalaga commented on July 29, 2024

Yes, there is no doubt that more coverage is better.

from camel-quarkus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.