Comments (6)
I clearly see the benefit of testing separately and having a separate project for each component that can serve as a basic quickstart.
OTOH, each separate integration test module will prolong the build by ~2 minutes. Do we really want that? My personal limit for CI is ~40mins. Now we are at ~28mins, IIRC. So we can basically do this, but maybe for the future, we should think of some sort of policy that would keep the CI run times reasonable. Testing several extensions in one IT module is actually one possible solution, so once again the question, is it really worth splitting now?
from camel-quarkus.
I think a reasonable time for CI can be more than 40 minutes.
from camel-quarkus.
I think a reasonable time for CI can be more than 40 minutes.
I wonder what is your upper bound for a CI job that verifies pull requests?
from camel-quarkus.
it depends on the dimension of a project: in camel we cannot do a full build because it's too much stuff for a single PR. I think up to 90 minutes is reasonable.
from camel-quarkus.
I clearly see the benefit of testing separately and having a separate project for each component that can serve as a basic quickstart.
OTOH, each separate integration test module will prolong the build by ~2 minutes. Do we really want that? My personal limit for CI is ~40mins. Now we are at ~28mins, IIRC. So we can basically do this, but maybe for the future, we should think of some sort of policy that would keep the CI run times reasonable. Testing several extensions in one IT module is actually one possible solution, so once again the question, is it really worth splitting now?
There's no rush to move them out of core now but we should provide more tests for every extensions to aver better coverage for native compiled code (as today the tests we have for nett4-http and infinispan are the bare minimum).
BTW, nothing is written in stones and we can always rethink our decisions and group modules when it make sense but IMHO, testing component extension inside the core one is just bad.
from camel-quarkus.
Yes, there is no doubt that more coverage is better.
from camel-quarkus.
Related Issues (20)
- Configure ArangoDB component to use the Quarkus managed Vertx instance HOT 1
- ical Dataformat fails in native HOT 1
- Caffeine time based eviction policy does not work in native mode HOT 7
- Caffeine does not work in native mode if stats are enabled
- Remove bytecode transformation workaround in aws2-kinesis HOT 1
- gRPC extension Gradle dev mode causes CNFE for io.quarkus.virtual.threads.VirtualThreadsConfig
- JPA testProducerNativeQuery fails for MySQL and MariaDB databases
- Add azure-key-vault native support
- hashicorp-vault extension does not work
- Camel debug is not working HOT 3
- [fips] Jdbc - mysql : test fails on FIPS enabled system when executed in "jdbc-grupped" module
- [fips] jdbc-grouped fails on FIPS in native HOT 1
- [fips] jdbc/db2 native should be disabled for FIPS
- JT400 Minor issue with resource allocated to another job
- Status code 404 when upgrading quarkus-langchain4j > 0.16.2 invoking: Rest Client method: 'io.quarkiverse.langchain4j.ollama.OllamaRestApi#chat'
- [quarkus-main] microprofile-fault-tolerance tests fail with CNFE for FallbackFunction
- Improve quarkus-langchain4j version alignment HOT 1
- Intermittent failure of master-openshift test
- camel-quarkus-syslog not compatible with quarkus-jdbc-oracle extension in native mode HOT 9
- cxf-soap SSL tests fail with Quarkus CXF 3.13.0
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from camel-quarkus.