Support named pointcuts about aop HOT 3 OPEN

I may have overlooked the named pointcut concepts, but how is it different from a simple constant ?

    <?php
    //define pointcut for all delete methods
    define('POINTCUT_DELETE', '**/*->delete*()');
    aop_add_before(POINTCUT_DELETE, $closure);

from aop.

True, on the language level of your extension that is about the same. We could have done that as well, I guess.

But when you combine named pointcuts with another expression, it becomes a little messy:

<?php
define('POINTCUT_DELETE', '**/*->delete*()');
aop_add_before('(Foo->bar() && ' . POINTCUT_DELETE . ') || Baz->Quux()' , $closure);

The other thing is, it pollutes the constant namespace - but only for a given PHP namespace, so it might not be that bad.

from aop.

Ok, I now understand your point.

We could as you propose include some kind of a pre-parse for selectors like

   <?php
    aop_pointcut_define('**/*->delete*()', 'pointcut_delete');
    aop_add_before('(Foo->bar() && pointcut_delete ) || Baz->Quux()' , $closure);

Maybe more then

   <?php
    aop_pointcut_define('**/*->delete*()', 'delete');
    aop_add_before('(method(Foo->bar()) && pointcut(delete) ) || method(Baz->Quux())' , $closure);

The global syntax is really to be think of. I'm really the kind of person who prefer simplicity over completeness in API, letting the user define his own "what the base syntax cannot do".

I think we'll have to wait for more feedback and decide the way to go with this.

from aop.