Comments (2)
apfitzge
commented on July 28, 2024
@carllin @AshwinSekar - I migrated this issue. My understanding from previous issue is it is not necessary for us to continue doing this holding.
@carllin if that is not the case, please let us know.
from agave.
AshwinSekar
commented on July 28, 2024
Confirmed with carl in April that votes do not need to be held in ClusterInfoVoteListener with the caveat that banking stage only drains the votes for slots on the working_bank's fork and leaves the remaining untouched.
The benefit of holding votes in ClusterInfoVoteListener is that if the leader decides to build it's first block off of fork1 and it's second block off of fork2, gossip votes for fork2 will still make it into the second block, even if they are filtered out for the first block.
Essentially we want to move this check:
agave/core/src/verified_vote_packets.rs
Lines 89 to 90 in a2eaf6d
Into here:
agave/core/src/banking_stage/latest_unprocessed_votes.rs
Lines 322 to 323 in a2eaf6d
from agave.
Related Issues (20)
- BankingStage: Vote Threads
- `simulateTransaction` incorrectly throws `TooManyAccountLocks` for <64 writeable accounts HOT 5
- BUILT_IN_INSTRUCTION_COSTS: ahash HOT 5
- Flaky Test: solana-unified-scheduler-pool tests::test_scheduler_drop_short_circuiting
- [Tracking] Core Transaction Type
- [Tracking] Scheduler Configurability
- Compile error when using the `offset_of` macro in solana-program crate
- TransactionBatchProcessor::load_and_execute_sanitized_transactions does not look at account_overrides when doing fee checks
- CostModel: builtins execution costs are inconsistent between cost-model and runtime
- compute-budget allocates constantly defined default-cost for builtin instructions
- spl-token withdraw-withheld-tokens silently fails HOT 1
- Feature Gate: Vote only on retransmitter signed FEC sets
- Feature Request: Make Solana Toolsuite more moduler HOT 1
- [Tracking] TransactionView
- $20 in $SOL to whoever can help me solve this getrandom error when i run anchor build HOT 1
- Improve error message for `program deploy` along with cli argument "keypair" help
- Loader-v3 programdata account size is not counted towards limit if executed through CPI
- Curves syscall: EdwardPoint and RistrettoPoint compression HOT 1
- [Tracking] lock_accounts performance
- error trying to interact with the tpuclient
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from agave.