Giter Club home page Giter Club logo

Comments (8)

MoojMidge avatar MoojMidge commented on August 21, 2024 1

There is no problem in just mentioning something, but I need details to actually do anything about it. It is easier to track things in separate issues with details provided, otherwise it will just get lost amongst the other discussion.

Is the "watched status" refresh problem also being corrected?

Try it and let me know. There has been recent changes made to fix this.

from plugin.video.youtube.

DjDiabolik avatar DjDiabolik commented on August 21, 2024

Some additional information.

The problem seems to only appear if you use the "Go to xxxx" function (how xxxx it's the youtube channel directly from "My Subscription" feed )
so if I open the channel from here:
immagine

If i open a channel directly from here:
immagine

"Registrations" from main list this thing doesn't happen

from plugin.video.youtube.

MoojMidge avatar MoojMidge commented on August 21, 2024

I think this is the same underlying issue as #776. Can you check if it is fixed in:
https://github.com/MoojMidge/plugin.video.youtube/releases/tag/v7.0.7.1

from plugin.video.youtube.

DjDiabolik avatar DjDiabolik commented on August 21, 2024

@MoojMidge exact.
you suggest me to try to better describe the problem with photos/screenshots and some details in a different issue....

Can you have also the 'unofficial' version of your 7.0.7.1 ?

sorry, my English isn't the best around :) Google Translator it's by big friends in some cases :)

EDIT
Unofficial available...
https://github.com/MoojMidge/plugin.video.youtube/releases/download/v7.0.7.1/plugin.video.youtube-7.0.7.1+unofficial.1.zip

from plugin.video.youtube.

DjDiabolik avatar DjDiabolik commented on August 21, 2024

Can test same issue whit 7.0.7.1 unofficial... this is screenshot of "My Subscription" feed:
immagine

Use "Go To" from here:
immagine

Obtain this:
immagine

Apparently this strange issue/trouble it's fixed... now the "view style" and also the "watched status icon" it's correctly work.

from plugin.video.youtube.

benyamin-codez avatar benyamin-codez commented on August 21, 2024

@DjDiabolik & @MoojMidge, this was the behaviour I've been seeing since I think v7.0.6.3. It might have been an earlier beta tbh. It would also occur during a Refresh of "My Subscriptions". @MoojMidge, I hadn't mentioned this because I saw you were working on the refresh codebase and I presumed it was just a work in progress.

In any case, both Refresh and Go to Channel_Name do appear to be working now using MoojMidge_v7.0.7.1.

Refresh appears to actually refresh again too, which is nice given it hasn't since the cache was introduced (v6...?). I noticed in debug logging that the refresh counts the refresh attempt (it has done this for some time). Is there a purpose to this or is it purely informational? Is the refresh rate-limited, i.e. are only a certain number of refreshes permitted (I previously stopped at four or five)?

It's worth noting, that instead of "spinning" during the refresh, the UI returns immediately. Some seconds later when the script finishes, the list is updated, i.e. there is no spinner displayed during the whole refresh. Should this be fixed?

from plugin.video.youtube.

MoojMidge avatar MoojMidge commented on August 21, 2024

@DjDiabolik - I didn't quite understand what the problem was that your were describing, but the screenshots have helped to explain. Thanks.

It was unrelated to #779 which is why I asked you to post a separate issue, but it turns out that #776 has the same cause.

@benyamin-codez - Kodi has various ways of updating the content of an existing listing. Unfortunately they all have various issues when used in different ways.

Refresh appears to actually refresh again too, which is nice given it hasn't since the cache was introduced (v6...?).

For a while now, the refresh was actually just a visual refresh rather than a refresh of the cached content.

Alternatively trying to update the container content within a window had issues where it could cause Kodi to load plugin content in a non-video window.

While trying to open a completely new window would often times lead to losing window navigation history and dumping the user back to the root of the video window.

All of these methods also run the risk of causing Kodi to crash if something else also activates a busy dialog (the spinner) at the same time.

To workaround these issues this plugin now uses the same method for all actions that programmatically load a listing, regardless of whether it is refreshing the current listing, or jumping to a different page in a listing, or opening a completely different listing - it loads the content in the background, caches the content if the loading worked, and only opens the window with the cached content if the loading worked.

I noticed in debug logging that the refresh counts the refresh attempt (it has done this for some time). Is there a purpose to this or is it purely informational?

One other issue that Kodi has is that it will refuse to open a window with the same address as the current window. This is why the refresh count changes - it causes the url to change allowing Kodi to open the window with the refreshed content that was newly loaded and cached.

there is no spinner displayed during the whole refresh. Should this be fixed?

This is an intentional consequence of the method chosen to load content, to avoid crashes. I suppose a notification can be shown instead, to indicate that something is loading.

from plugin.video.youtube.

DjDiabolik avatar DjDiabolik commented on August 21, 2024

@MoojMidge I knew the "next page" problem in "My Subscriptions" and this whit miniature instead "watched or unwatched" status they could not correlate.
I saw it as a minor problem and above all not invalidating the general functioning of the addon itself and so I mentioned it like that out of curiosity.

Is the "watched status" refresh problem also being corrected? I had an issue open perhaps years ago regarding something like this (if i remember somethigs like watched status not correctly preserved when you step back from page to previous page or somethings similar) .

from plugin.video.youtube.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.