Enable CUPS auto discovery about cups-docker HOT 7 OPEN

I've included multiple architecture support in the PR, it should be ready now.

from cups-docker.

Thanks for all the work. I'll test it out over the weekend and merge the request. Unfortunately I will not be able to get to this till Friday.

from cups-docker.

Essentially, you need to create three services.

• avahi-daemon in /etc/services.d/avahi-daemon/run

#!/usr/bin/execlineb -P
/usr/sbin/avahi-daemon -s

• cups in /etc/services.d/cups/run

#!/usr/bin/execlineb -P
/usr/sbin/cupsd -l

• cups-browsed in /etc/services.d/cups-browsed/run

#!/usr/bin/execlineb -P
/usr/sbin/cups-browsed

And modify your Dockerfile accordingly.

FROM debian:stable-slim

# ENV variables
ENV DEBIAN_FRONTEND noninteractive
ENV TZ "America/New_York"
ENV CUPSADMIN admin
ENV CUPSPASSWORD password


LABEL org.opencontainers.image.source="https://github.com/anujdatar/cups-docker"
LABEL org.opencontainers.image.description="CUPS Printer Server"
LABEL org.opencontainers.image.author="Anuj Datar <[email protected]>"
LABEL org.opencontainers.image.url="https://github.com/anujdatar/cups-docker/blob/main/README.md"
LABEL org.opencontainers.image.licenses=MIT

# Install s6-overlay
ADD https://github.com/just-containers/s6-overlay/releases/download/v2.2.0.3/s6-overlay-amd64.tar.gz /tmp/

# Install dependencies
RUN apt-get update -qq  && apt-get upgrade -qqy \
    && apt-get install -qqy \
    apt-utils \
    usbutils \
    cups \
    cups-filters \
    printer-driver-all \
    printer-driver-cups-pdf \
    printer-driver-foo2zjs \
    foomatic-db-compressed-ppds \
    openprinting-ppds \
    hpijs-ppds \
    hp-ppd \
    hplip \
    avahi-daemon \
    && tar xzf /tmp/s6-overlay-amd64.tar.gz -C / \
    && rm /tmp/s6-overlay-amd64.tar.gz \
    && apt-get clean \
    && rm -rf /var/lib/apt/lists/*

EXPOSE 631
EXPOSE 5353/udp

# Baked-in config file changes
RUN sed -i 's/Listen localhost:631/Listen 0.0.0.0:631/' /etc/cups/cupsd.conf && \
    sed -i 's/Browsing Off/Browsing On/' /etc/cups/cupsd.conf && \
    sed -i 's/<Location \/>/<Location \/>\n  Allow All/' /etc/cups/cupsd.conf && \
    sed -i 's/<Location \/admin>/<Location \/admin>\n  Allow All\n  Require user @SYSTEM/' /etc/cups/cupsd.conf && \
    sed -i 's/<Location \/admin\/conf>/<Location \/admin\/conf>\n  Allow All/' /etc/cups/cupsd.conf && \
    echo "ServerAlias *" >> /etc/cups/cupsd.conf && \
    echo "DefaultEncryption Never" >> /etc/cups/cupsd.conf

# back up cups configs in case used does not add their own
RUN cp -rp /etc/cups /etc/cups-bak
VOLUME [ "/etc/cups" ]

# Add s6 service definitions
COPY ./services /etc/services.d

# Command to start s6-init
CMD ["/init"]

Something along these lines

from cups-docker.

aah, okay thanks.. I do not have a lot of experience with s6, or managing multiple services inside containers. Thanks for the examples. I honestly did not get a lot of time to experiment over the holidays. I literally only got a couple of hours to work on it, I know it doesn't work yet. I'll hopefully get to work on it again in a few weeks. Work's too busy at the moment.

Anuj

from cups-docker.

I could help you create this PR, but I have to think about how to incorporate the existing entrypoint script for adding user based on the env variable first.

from cups-docker.

I've created a PR for this, the only thing left to think about is how to build s6-overlay supporting multiple architecture.

I think you could add a script file which will be executed as one of the Dockerfile steps.

Something like this.

if [[ "${TARGETARCH}" == "amd64" ]]; then
    S6_OVERLAY_ARCH="x86_64"
elif [[ "${TARGETARCH}" == "arm64" ]]; then
    S6_OVERLAY_ARCH="aarch64"
fi

wget -qO- "https://github.com/just-containers/s6-overlay/releases/download/v${S6_OVERLAY_VERSION}/s6-overlay-${S6_OVERLAY_ARCH}.tar.xz" |
    tar -C / -Jxpf -

But I'm not sure how we could know the TARGETARCH via github action, based on the quick search, it should be something like this.

...
      - name: Build and push images
        uses: docker/build-push-action@v4
        build-args: |
            TARGETARCH=${{ matrix.arch }}
...

Updated

I found it mentioned here and here, TARGETARCH will be passed automatically with BuildKit.

Which architecture to use depending on your TARGETARCH

The ${arch} part in the s6-overlay-${arch}.tar.xz tarball uses
the naming conventions of gcc, which are not the ones that Docker
uses. (Everyone does something different in this field depending on
their needs, and no solution is better than any other, but the Docker
one is worse than others because its naming is inconsistent. The gcc
convention is better for us because it simplifies our builds greatly and
makes them more maintainable.)

The following table should help you find the right tarball for you
if you're using the TARGETARCH value provided by Docker:

from cups-docker.

That's ok, let me know if any changes are required.

from cups-docker.