Describe the bug Assume you have a module that references ot

terraform init does not always run <

Would what described as item 3 (<code class="notransl

terraform_validate fails on already initialised module after adding a module about pre-commit-terraform HOT 4 CLOSED

sblask commented on June 3, 2024

terraform_validate fails on already initialised module after adding a module

from pre-commit-terraform.

Comments (4)

MaxymVlasov commented on June 3, 2024 1

terraform init does not always run

pre-commit-terraform/hooks/terraform_validate.sh

Lines 113 to 126 in 95fc56f

 # First try `terraform validate` with the hope that all deps are 

 # pre-installed. That is needed for cases when `.terraform/modules` 

 # or `.terraform/providers` missed AND that is expected. 

 terraform validate "${args[@]}" &> /dev/null && { 

 exit_code=$? 

 return $exit_code 

 } 

 # In case `terraform validate` failed to execute 

 # - check is simple `terraform init` will help 

 common::terraform_init 'terraform validate' "$dir_path" || { 

 exit_code=$? 

 return $exit_code 

 }

Addition to File System it +- save operation, when removal - is not, by definition. Manual changes in .terraform/ are rare, but still exist.
Making two full validations are time-consuming operation
For that flag additional deps (jq) is required, when other parts of hook able to work without it

Basically, all this stuff is already specified in README

In any case, that change can not be done until v2.0 which will come only when there are no other possibilities to continue making improvements to v1 (we will not support two versions in parallel)

To not forget, I added the next point to 2.0.0 [BREAKING CHANGES] milestone:

Make hooks flags, which are highly used to tweak hooks, enabled by default

from pre-commit-terraform.

yermulnik commented on June 3, 2024

Would what described as item 3 (--retry-once-with-cleanup=true) at https://github.com/antonbabenko/pre-commit-terraform?tab=readme-ov-file#terraform_validate help in your case?

from pre-commit-terraform.

MaxymVlasov commented on June 3, 2024

Work as expected. terraform validate will fail too in such conditions.

As George mentioned above, please use --retry-once-with-cleanup=true to deal with that kind of issue.

from pre-commit-terraform.

sblask commented on June 3, 2024

Thanks for the help! I think it would make a lot of sense to make the retry the default? Running terraform init is run by default to make things "just work" so running it again to make it "just work" in more situations would be consistent behaviour?

from pre-commit-terraform.

Recommend Projects

terraform_validate fails on already initialised module after adding a module about pre-commit-terraform HOT 4 CLOSED

Comments (4)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	# First try `terraform validate` with the hope that all deps are
	# pre-installed. That is needed for cases when `.terraform/modules`
	# or `.terraform/providers` missed AND that is expected.
	terraform validate "${args[@]}" &> /dev/null && {
	exit_code=$?
	return $exit_code
	}

	# In case `terraform validate` failed to execute
	# - check is simple `terraform init` will help
	common::terraform_init 'terraform validate' "$dir_path" \|\| {
	exit_code=$?
	return $exit_code
	}