Giter Club home page Giter Club logo

Comments (4)

antfu avatar antfu commented on August 18, 2024

Sure, PR welcome :)

from shikiji.

wststone avatar wststone commented on August 18, 2024

Sure, PR welcome :)

Adding a cache to rehypeShikiji should be pretty doable like in the snippet I showed. But i'm not very familiar with textmate's internal implementation as to how to cache the result of _loadgrammer, any guidance on where to look in the source code and how to optimize it, would adding an cache option on the top level in gethighlighter a good idea?

from shikiji.

antfu avatar antfu commented on August 18, 2024

Considering there are multiple layers to cache (code-hast cache, code-html cache, transformers cache, etc.), I think it's better to not implement the cache in core, but in the integrations instead (e.g., the remark plugin etc.). Also in mind that we might need to allow users to provide custom cache implementation like LRU, otherwise it might lead to memleak.

from shikiji.

wststone avatar wststone commented on August 18, 2024

I've just submitted a PR here: #80

For the moment, I haven't found a way to optimize or cache the grammar loading without touching the core, especially as it's invoked from the top level on each real-time render.

from shikiji.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.